Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Side by Side Diff: chrome/browser/media/router/discovery/dial/safe_dial_device_description_parser.cc

Issue 2701633002: [Media Router] Add DialMediaSinkService and DeviceDescriptionService (Closed)
Patch Set: resolve code review comments from Mark cont Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/media/router/discovery/dial/safe_dial_device_descriptio n_parser.h" 5 #include "chrome/browser/media/router/discovery/dial/safe_dial_device_descriptio n_parser.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "chrome/grit/generated_resources.h" 9 #include "chrome/grit/generated_resources.h"
10 #include "content/public/browser/browser_thread.h" 10 #include "content/public/browser/browser_thread.h"
(...skipping 14 matching lines...) Expand all
25 25
26 device_description_callback_ = callback; 26 device_description_callback_ = callback;
27 27
28 utility_process_mojo_client_ = 28 utility_process_mojo_client_ =
29 base::MakeUnique<content::UtilityProcessMojoClient< 29 base::MakeUnique<content::UtilityProcessMojoClient<
30 chrome::mojom::DialDeviceDescriptionParser>>( 30 chrome::mojom::DialDeviceDescriptionParser>>(
31 l10n_util::GetStringUTF16( 31 l10n_util::GetStringUTF16(
32 IDS_UTILITY_PROCESS_DIAL_DEVICE_DESCRIPTION_PARSER_NAME)); 32 IDS_UTILITY_PROCESS_DIAL_DEVICE_DESCRIPTION_PARSER_NAME));
33 33
34 utility_process_mojo_client_->set_error_callback(base::Bind( 34 utility_process_mojo_client_->set_error_callback(base::Bind(
35 &SafeDialDeviceDescriptionParser::OnParseDeviceDescriptionFailed, 35 &SafeDialDeviceDescriptionParser::OnParseDeviceDescriptionFailed, this));
36 base::Unretained(this)));
37 36
38 // This starts utility process in the background. 37 // This starts utility process in the background.
39 utility_process_mojo_client_->Start(); 38 utility_process_mojo_client_->Start();
40 39
41 // This call is queued up until the Mojo message pipe has been established to 40 // This call is queued up until the Mojo message pipe has been established to
42 // the service running in the utility process. 41 // the service running in the utility process.
43 utility_process_mojo_client_->service()->ParseDialDeviceDescription( 42 utility_process_mojo_client_->service()->ParseDialDeviceDescription(
44 xml_text, 43 xml_text,
45 base::Bind( 44 base::Bind(
46 &SafeDialDeviceDescriptionParser::OnParseDeviceDescriptionComplete, 45 &SafeDialDeviceDescriptionParser::OnParseDeviceDescriptionComplete,
47 base::Unretained(this))); 46 this));
48 } 47 }
49 48
50 void SafeDialDeviceDescriptionParser::OnParseDeviceDescriptionComplete( 49 void SafeDialDeviceDescriptionParser::OnParseDeviceDescriptionComplete(
51 chrome::mojom::DialDeviceDescriptionPtr device_description) { 50 chrome::mojom::DialDeviceDescriptionPtr device_description) {
52 DCHECK(thread_checker_.CalledOnValidThread()); 51 DCHECK(thread_checker_.CalledOnValidThread());
53 52
54 utility_process_mojo_client_.reset(); // Terminate the utility process. 53 utility_process_mojo_client_.reset(); // Terminate the utility process.
55 54
56 DCHECK(device_description_callback_); 55 DCHECK(device_description_callback_);
57 device_description_callback_.Run(std::move(device_description)); 56 device_description_callback_.Run(std::move(device_description));
58 } 57 }
59 58
60 void SafeDialDeviceDescriptionParser::OnParseDeviceDescriptionFailed() { 59 void SafeDialDeviceDescriptionParser::OnParseDeviceDescriptionFailed() {
61 DCHECK(thread_checker_.CalledOnValidThread()); 60 DCHECK(thread_checker_.CalledOnValidThread());
62 61
63 utility_process_mojo_client_.reset(); // Terminate the utility process. 62 utility_process_mojo_client_.reset(); // Terminate the utility process.
64 63
65 DCHECK(device_description_callback_); 64 DCHECK(device_description_callback_);
66 device_description_callback_.Run(nullptr); 65 device_description_callback_.Run(nullptr);
67 } 66 }
68 67
69 } // namespace media_router 68 } // namespace media_router
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698