[Media Router] Add DialMediaSinkService and DeviceDescriptionService

chrome/browser/media/router/discovery/media_sink_internal.cc

Index: chrome/browser/media/router/discovery/media_sink_internal.cc
diff --git a/chrome/browser/media/router/discovery/media_sink_internal.cc b/chrome/browser/media/router/discovery/media_sink_internal.cc
index fe381f267f09683951e6190f6482059befb260d0..97fb762c0b83ba0707037608c4b24e52a61e7f37 100644
--- a/chrome/browser/media/router/discovery/media_sink_internal.cc
+++ b/chrome/browser/media/router/discovery/media_sink_internal.cc
@@ -64,6 +64,10 @@ bool MediaSinkInternal::operator==(const MediaSinkInternal& other) const {
   return false;
 }
 
+bool MediaSinkInternal::operator!=(const MediaSinkInternal& other) const {
+  return !operator==(other);

[mark a. foltz, 2017/04/12 00:17:18]

Nice :)  I did not know this trick and would have written !(*this == other)

[zhaobin, 2017/04/18 06:58:28]

Acknowledged.

+}
+
 void MediaSinkInternal::set_sink(const MediaSink& sink) {
   sink_ = sink;
 }
@@ -154,6 +158,12 @@ void MediaSinkInternal::InternalCleanup() {
 }
 
 DialSinkExtraData::DialSinkExtraData() = default;
+DialSinkExtraData::DialSinkExtraData(const std::string& ip_address,
+                                     const std::string& model_name,
+                                     const std::string& app_url)
+    : model_name(model_name), app_url(app_url) {
+  DCHECK(this->ip_address.AssignFromIPLiteral(ip_address));

[mark a. foltz, 2017/04/12 00:17:18]

This won't be called in release builds, and I feel like we should not check in
unit tests that are guaranteed to fail in release builds.

[zhaobin, 2017/04/18 06:58:27]

Code removed.

+}
 DialSinkExtraData::DialSinkExtraData(const DialSinkExtraData& other) = default;
 DialSinkExtraData::~DialSinkExtraData() = default;