Chromium Code Reviews
DescriptionRevert of Move postGC out of CrossThreadPersistentRegion::LockScope (patchset #2 id:20001 of https://codereview.chromium.org/2695063005/ )
Reason for revert:
Broke build.
crbug.com/692982
Original issue's description:
> Move postGC out of CrossThreadPersistentRegion::LockScope
>
> Some finalizers/prefinalizers acquire locks, causing a dead lock when CrossThreadPersistent tries to acquire the CrossThreadPersistentRegion lock.
>
> This CL moves the postGC step outside of the CrossThreadPersistentRegion::LockScope. This should be okay as the CrossThreadPersistentRegion::LockScope only exists to avoid add/deletetion of CrossThreadPersistentNodes during marking.
>
> BUG=681527, 684856, 685624, 685624
>
> Review-Url: https://codereview.chromium.org/2686533003
> Cr-Commit-Position: refs/heads/master@{#450251}
> (cherry picked from commit 52b19c8f68c222c08944af937a01f3ff7e46705c)
>
> Review-Url: https://codereview.chromium.org/2695063005 .
> Cr-Commit-Position: refs/branch-heads/2987@{#539}
> Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
> Committed: https://chromium.googlesource.com/chromium/src/+/590a7c6ceb9bea92bbce8e7636406ed6ea39bfe8
TBR=
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=681527, 684856, 685624, 685624
Review-Url: https://codereview.chromium.org/2701513003
Cr-Commit-Position: refs/branch-heads/2987@{#541}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Committed: https://chromium.googlesource.com/chromium/src/+/3d80b9d4de29bc69458e1c27eb8bce181d7dcb27
Patch Set 1 #
Messages
Total messages: 11 (6 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||