Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2701513003: Revert of Move postGC out of CrossThreadPersistentRegion::LockScope (Closed)

Created:
3 years, 10 months ago by keishi
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Revert of Move postGC out of CrossThreadPersistentRegion::LockScope (patchset #2 id:20001 of https://codereview.chromium.org/2695063005/ ) Reason for revert: Broke build. crbug.com/692982 Original issue's description: > Move postGC out of CrossThreadPersistentRegion::LockScope > > Some finalizers/prefinalizers acquire locks, causing a dead lock when CrossThreadPersistent tries to acquire the CrossThreadPersistentRegion lock. > > This CL moves the postGC step outside of the CrossThreadPersistentRegion::LockScope. This should be okay as the CrossThreadPersistentRegion::LockScope only exists to avoid add/deletetion of CrossThreadPersistentNodes during marking. > > BUG=681527, 684856, 685624, 685624 > > Review-Url: https://codereview.chromium.org/2686533003 > Cr-Commit-Position: refs/heads/master@{#450251} > (cherry picked from commit 52b19c8f68c222c08944af937a01f3ff7e46705c) > > Review-Url: https://codereview.chromium.org/2695063005 . > Cr-Commit-Position: refs/branch-heads/2987@{#539} > Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} > Committed: https://chromium.googlesource.com/chromium/src/+/590a7c6ceb9bea92bbce8e7636406ed6ea39bfe8 TBR= # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=681527, 684856, 685624, 685624 Review-Url: https://codereview.chromium.org/2701513003 Cr-Commit-Position: refs/branch-heads/2987@{#541} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/3d80b9d4de29bc69458e1c27eb8bce181d7dcb27

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -133 lines) Patch
M third_party/WebKit/Source/platform/heap/Heap.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/Heap.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.h View 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.cpp View 3 chunks +117 lines, -122 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
keishi
Created Revert of Move postGC out of CrossThreadPersistentRegion::LockScope
3 years, 10 months ago (2017-02-16 09:26:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2701513003/1
3 years, 10 months ago (2017-02-16 09:27:07 UTC) #3
commit-bot: I haz the power
Prior attempt to commit was detected, but we were not able to check whether the ...
3 years, 10 months ago (2017-02-16 09:33:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2701513003/1
3 years, 10 months ago (2017-02-16 09:49:10 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-16 09:51:42 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3d80b9d4de29bc69458e1c27eb8b...

Powered by Google App Engine
This is Rietveld 408576698