Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2695063005: Move postGC out of CrossThreadPersistentRegion::LockScope (Closed)

Created:
3 years, 10 months ago by keishi
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Move postGC out of CrossThreadPersistentRegion::LockScope Some finalizers/prefinalizers acquire locks, causing a dead lock when CrossThreadPersistent tries to acquire the CrossThreadPersistentRegion lock. This CL moves the postGC step outside of the CrossThreadPersistentRegion::LockScope. This should be okay as the CrossThreadPersistentRegion::LockScope only exists to avoid add/deletetion of CrossThreadPersistentNodes during marking. BUG=681527, 684856, 685624, 685624 Review-Url: https://codereview.chromium.org/2686533003 Cr-Commit-Position: refs/heads/master@{#450251} (cherry picked from commit 52b19c8f68c222c08944af937a01f3ff7e46705c) Review-Url: https://codereview.chromium.org/2695063005 . Cr-Commit-Position: refs/branch-heads/2987@{#539} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/590a7c6ceb9bea92bbce8e7636406ed6ea39bfe8

Patch Set 1 #

Patch Set 2 : Move postGC out of CrossThreadPersistentRegion::LockScope #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -97 lines) Patch
M third_party/WebKit/Source/platform/heap/Heap.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/Heap.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.h View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.cpp View 3 chunks +100 lines, -95 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
keishi
Committed patchset #2 (id:20001) manually as 590a7c6ceb9bea92bbce8e7636406ed6ea39bfe8.
3 years, 10 months ago (2017-02-16 08:01:39 UTC) #2
keishi
3 years, 10 months ago (2017-02-16 09:26:25 UTC) #3
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2701513003/ by keishi@chromium.org.

The reason for reverting is: Broke build.
crbug.com/692982.

Powered by Google App Engine
This is Rietveld 408576698