Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Issue 2701513002: [Video] Fix keyframe distance average calculations. (Closed)

Created:
3 years, 10 months ago by whywhat
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

[Video] Fix keyframe distance average calculations. Found a few problems with the way the keyframe distance is calculated and passed from the decoder to WMPI: 1. as soon as the video decoder is stopped we reset the average - meaning we will stop considering optimizing playback for the video 2. we have to wait for more than 4 keyframes to start optimizing video playback, this can take seconds 3. audio decoder resets the average to 0 in pipeline's shared state BUG=688618 TEST=Manual Review-Url: https://codereview.chromium.org/2643103002 Cr-Commit-Position: refs/heads/master@{#444955} (cherry picked from commit 8127a839bf18e618aaf7a8cad95440c6cd3f9f76) Review-Url: https://codereview.chromium.org/2701513002 . Cr-Commit-Position: refs/branch-heads/2987@{#526} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/7837cbd3bb82ec56e15ca5f041ad59bf7d88a85d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -9 lines) Patch
M media/base/pipeline_impl.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M media/base/pipeline_status.h View 2 chunks +2 lines, -1 line 0 comments Download
M media/filters/decoder_stream_traits.cc View 2 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
whywhat
3 years, 10 months ago (2017-02-15 19:32:27 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7837cbd3bb82ec56e15ca5f041ad59bf7d88a85d.

Powered by Google App Engine
This is Rietveld 408576698