Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 2643103002: [Video] Fix keyframe distance average calculations. (Closed)

Created:
3 years, 11 months ago by whywhat
Modified:
3 years, 11 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org, posciak+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Video] Fix keyframe distance average calculations. Found a few problems with the way the keyframe distance is calculated and passed from the decoder to WMPI: 1. as soon as the video decoder is stopped we reset the average - meaning we will stop considering optimizing playback for the video 2. we have to wait for more than 4 keyframes to start optimizing video playback, this can take seconds 3. audio decoder resets the average to 0 in pipeline's shared state BUG=None TEST=Manual Review-Url: https://codereview.chromium.org/2643103002 Cr-Commit-Position: refs/heads/master@{#444955} Committed: https://chromium.googlesource.com/chromium/src/+/8127a839bf18e618aaf7a8cad95440c6cd3f9f76

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -9 lines) Patch
M media/base/pipeline_impl.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M media/base/pipeline_status.h View 2 chunks +2 lines, -1 line 0 comments Download
M media/filters/decoder_stream_traits.cc View 2 chunks +5 lines, -6 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (8 generated)
whywhat
PTaL
3 years, 11 months ago (2017-01-19 21:02:35 UTC) #2
DaleCurtis
lgtm
3 years, 11 months ago (2017-01-19 21:10:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2643103002/1
3 years, 11 months ago (2017-01-20 02:09:53 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 02:16:12 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8127a839bf18e618aaf7a8cad954...

Powered by Google App Engine
This is Rietveld 408576698