third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp - Issue 2701413003: Range: node offsets should be unsigned.

Unified Diff: third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp

Issue 2701413003: Range: node offsets should be unsigned. (Closed)

Patch Set: Resolve std::numeric_limits<int>::max() leftover Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« third_party/WebKit/Source/core/dom/RangeBoundaryPoint.h ('K') | « third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp ('k') | third_party/WebKit/Source/core/editing/iterators/CharacterIteratorTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp

diff --git a/third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp b/third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp

index 549b61c281cdda036fd47b024cf1a2e1c533767c..b7b041535dd8116f787aab960ee6dc15f520fb37 100644

--- a/third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp

+++ b/third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp

@@ -209,8 +209,8 @@ TEST_F(VisibleSelectionTest, Initialisation) {

EXPECT_TRUE(selectionInFlatTree.isCaret());

Range* range = firstRangeOf(selection);

- EXPECT_EQ(0, range->startOffset());

- EXPECT_EQ(0, range->endOffset());

+ EXPECT_EQ(0u, range->startOffset());

+ EXPECT_EQ(0u, range->endOffset());

EXPECT_EQ("", range->text());

testFlatTreePositionsToEqualToDOMTreePositions(selection,

selectionInFlatTree);

@@ -351,8 +351,8 @@ TEST_F(VisibleSelectionTest, WordGranularity) {

expandUsingGranularity(selectionInFlatTree, WordGranularity);

Range* range = firstRangeOf(selection);

- EXPECT_EQ(0, range->startOffset());

- EXPECT_EQ(5, range->endOffset());

+ EXPECT_EQ(0u, range->startOffset());

+ EXPECT_EQ(5u, range->endOffset());

EXPECT_EQ("Lorem", range->text());

testFlatTreePositionsToEqualToDOMTreePositions(selection,

selectionInFlatTree);

@@ -367,8 +367,8 @@ TEST_F(VisibleSelectionTest, WordGranularity) {

expandUsingGranularity(selectionInFlatTree, WordGranularity);

Range* range = firstRangeOf(selection);

- EXPECT_EQ(6, range->startOffset());

- EXPECT_EQ(11, range->endOffset());

+ EXPECT_EQ(6u, range->startOffset());

+ EXPECT_EQ(11u, range->endOffset());

EXPECT_EQ("ipsum", range->text());

testFlatTreePositionsToEqualToDOMTreePositions(selection,

selectionInFlatTree);

@@ -385,8 +385,8 @@ TEST_F(VisibleSelectionTest, WordGranularity) {

expandUsingGranularity(selectionInFlatTree, WordGranularity);

Range* range = firstRangeOf(selection);

- EXPECT_EQ(5, range->startOffset());

- EXPECT_EQ(6, range->endOffset());

+ EXPECT_EQ(5u, range->startOffset());

+ EXPECT_EQ(6u, range->endOffset());

EXPECT_EQ(" ", range->text());

testFlatTreePositionsToEqualToDOMTreePositions(selection,

selectionInFlatTree);

@@ -403,8 +403,8 @@ TEST_F(VisibleSelectionTest, WordGranularity) {

expandUsingGranularity(selectionInFlatTree, WordGranularity);

Range* range = firstRangeOf(selection);

- EXPECT_EQ(26, range->startOffset());

- EXPECT_EQ(27, range->endOffset());

+ EXPECT_EQ(26u, range->startOffset());

+ EXPECT_EQ(27u, range->endOffset());

EXPECT_EQ(",", range->text());

testFlatTreePositionsToEqualToDOMTreePositions(selection,

selectionInFlatTree);

@@ -419,8 +419,8 @@ TEST_F(VisibleSelectionTest, WordGranularity) {

expandUsingGranularity(selectionInFlatTree, WordGranularity);

Range* range = firstRangeOf(selection);

- EXPECT_EQ(27, range->startOffset());

- EXPECT_EQ(28, range->endOffset());

+ EXPECT_EQ(27u, range->startOffset());

+ EXPECT_EQ(28u, range->endOffset());

EXPECT_EQ(" ", range->text());

testFlatTreePositionsToEqualToDOMTreePositions(selection,

selectionInFlatTree);

@@ -435,8 +435,8 @@ TEST_F(VisibleSelectionTest, WordGranularity) {

expandUsingGranularity(selectionInFlatTree, WordGranularity);

Range* range = firstRangeOf(selection);

- EXPECT_EQ(0, range->startOffset());

- EXPECT_EQ(5, range->endOffset());

+ EXPECT_EQ(0u, range->startOffset());

+ EXPECT_EQ(5u, range->endOffset());

EXPECT_EQ("Lorem", range->text());

testFlatTreePositionsToEqualToDOMTreePositions(selection,

selectionInFlatTree);

@@ -451,8 +451,8 @@ TEST_F(VisibleSelectionTest, WordGranularity) {

expandUsingGranularity(selectionInFlatTree, WordGranularity);

Range* range = firstRangeOf(selection);

- EXPECT_EQ(0, range->startOffset());

- EXPECT_EQ(11, range->endOffset());

+ EXPECT_EQ(0u, range->startOffset());

+ EXPECT_EQ(11u, range->endOffset());

EXPECT_EQ("Lorem ipsum", range->text());

testFlatTreePositionsToEqualToDOMTreePositions(selection,

selectionInFlatTree);