third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp - Issue 2701413003: Range: node offsets should be unsigned.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp

Issue 2701413003: Range: node offsets should be unsigned. (Closed)

Patch Set: Resolve std::numeric_limits<int>::max() leftover Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/dom/RangeBoundaryPoint.h ('K') | « third_party/WebKit/Source/core/dom/StaticRangeTest.cpp ('k') | third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp

diff --git a/third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp b/third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp

index af4913f8026b15cf7dc9fdb0f1393e7f3ac4e5c8..11eca71312aadefe3c1a0616166e393b34ee4a80 100644

--- a/third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp

+++ b/third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp

@@ -175,8 +175,8 @@ TEST_F(InputMethodControllerTest, SetCompositionFromExistingText) {

controller().setCompositionFromExistingText(underlines, 0, 5);

Range* range = controller().compositionRange();

- EXPECT_EQ(0, range->startOffset());

- EXPECT_EQ(5, range->endOffset());

+ EXPECT_EQ(0u, range->startOffset());

+ EXPECT_EQ(5u, range->endOffset());

PlainTextRange plainTextRange(PlainTextRange::create(*div, *range));

EXPECT_EQ(0u, plainTextRange.start());

@@ -384,8 +384,8 @@ TEST_F(InputMethodControllerTest,

controller().setCompositionFromExistingText(underlines, 0, 5);

Range* range = controller().compositionRange();

- EXPECT_EQ(1, range->startOffset());

- EXPECT_EQ(6, range->endOffset());

+ EXPECT_EQ(1u, range->startOffset());

+ EXPECT_EQ(6u, range->endOffset());

PlainTextRange plainTextRange(PlainTextRange::create(*div, *range));

EXPECT_EQ(0u, plainTextRange.start());