third_party/WebKit/Source/core/editing/iterators/CharacterIteratorTest.cpp - Issue 2701413003: Range: node offsets should be unsigned.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/iterators/CharacterIteratorTest.cpp

Issue 2701413003: Range: node offsets should be unsigned. (Closed)

Patch Set: Resolve std::numeric_limits<int>::max() leftover Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/dom/RangeBoundaryPoint.h ('K') | « third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp ('k') | third_party/WebKit/Source/web/tests/TextFinderTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/iterators/CharacterIteratorTest.cpp

diff --git a/third_party/WebKit/Source/core/editing/iterators/CharacterIteratorTest.cpp b/third_party/WebKit/Source/core/editing/iterators/CharacterIteratorTest.cpp

index a5e54ed9e9ac9361d92d28f95592e5dd34648347..ffba4aa4a404c647be85dd6d5c6989bcf21bdf54 100644

--- a/third_party/WebKit/Source/core/editing/iterators/CharacterIteratorTest.cpp

+++ b/third_party/WebKit/Source/core/editing/iterators/CharacterIteratorTest.cpp

@@ -61,8 +61,8 @@ TEST_F(CharacterIteratorTest, CollapsedSubrange) {

Node* textNode = document().getElementById("div")->lastChild();

Range* entireRange = Range::create(document(), textNode, 1, textNode, 4);

- EXPECT_EQ(1, entireRange->startOffset());

- EXPECT_EQ(4, entireRange->endOffset());

+ EXPECT_EQ(1u, entireRange->startOffset());

+ EXPECT_EQ(4u, entireRange->endOffset());

const EphemeralRange& result =

calculateCharacterSubrange(EphemeralRange(entireRange), 2, 0);