Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: third_party/WebKit/Source/core/dom/StaticRangeTest.cpp

Issue 2701413003: Range: node offsets should be unsigned. (Closed)
Patch Set: Resolve std::numeric_limits<int>::max() leftover Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/StaticRangeTest.cpp
diff --git a/third_party/WebKit/Source/core/dom/StaticRangeTest.cpp b/third_party/WebKit/Source/core/dom/StaticRangeTest.cpp
index 1fd88c5410d6b4651deaa4abd48aa2ef00c607ed..885cfe740028076a18a68596ff0431dfd37c8ec0 100644
--- a/third_party/WebKit/Source/core/dom/StaticRangeTest.cpp
+++ b/third_party/WebKit/Source/core/dom/StaticRangeTest.cpp
@@ -66,29 +66,29 @@ TEST_F(StaticRangeTest, SplitTextNodeRangeWithinText) {
// Range should mutate.
EXPECT_TRUE(range04->boundaryPointsValid());
EXPECT_EQ(oldText, range04->startContainer());
- EXPECT_EQ(0, range04->startOffset());
+ EXPECT_EQ(0u, range04->startOffset());
EXPECT_EQ(newText, range04->endContainer());
- EXPECT_EQ(2, range04->endOffset());
+ EXPECT_EQ(2u, range04->endOffset());
EXPECT_TRUE(range02->boundaryPointsValid());
EXPECT_EQ(oldText, range02->startContainer());
- EXPECT_EQ(0, range02->startOffset());
+ EXPECT_EQ(0u, range02->startOffset());
EXPECT_EQ(oldText, range02->endContainer());
- EXPECT_EQ(2, range02->endOffset());
+ EXPECT_EQ(2u, range02->endOffset());
// Our implementation always moves the boundary point at the separation point
// to the end of the original text node.
EXPECT_TRUE(range22->boundaryPointsValid());
EXPECT_EQ(oldText, range22->startContainer());
- EXPECT_EQ(2, range22->startOffset());
+ EXPECT_EQ(2u, range22->startOffset());
EXPECT_EQ(oldText, range22->endContainer());
- EXPECT_EQ(2, range22->endOffset());
+ EXPECT_EQ(2u, range22->endOffset());
EXPECT_TRUE(range24->boundaryPointsValid());
EXPECT_EQ(oldText, range24->startContainer());
- EXPECT_EQ(2, range24->startOffset());
+ EXPECT_EQ(2u, range24->startOffset());
EXPECT_EQ(newText, range24->endContainer());
- EXPECT_EQ(2, range24->endOffset());
+ EXPECT_EQ(2u, range24->endOffset());
// StaticRange shouldn't mutate.
EXPECT_EQ(oldText, staticRange04->startContainer());
@@ -154,41 +154,41 @@ TEST_F(StaticRangeTest, SplitTextNodeRangeOutsideText) {
// Range should mutate.
EXPECT_TRUE(rangeOuterOutside->boundaryPointsValid());
EXPECT_EQ(outer, rangeOuterOutside->startContainer());
- EXPECT_EQ(0, rangeOuterOutside->startOffset());
+ EXPECT_EQ(0u, rangeOuterOutside->startOffset());
EXPECT_EQ(outer, rangeOuterOutside->endContainer());
- EXPECT_EQ(6,
+ EXPECT_EQ(6u,
rangeOuterOutside
->endOffset()); // Increased by 1 since a new node is inserted.
EXPECT_TRUE(rangeOuterInside->boundaryPointsValid());
EXPECT_EQ(outer, rangeOuterInside->startContainer());
- EXPECT_EQ(1, rangeOuterInside->startOffset());
+ EXPECT_EQ(1u, rangeOuterInside->startOffset());
EXPECT_EQ(outer, rangeOuterInside->endContainer());
- EXPECT_EQ(5, rangeOuterInside->endOffset());
+ EXPECT_EQ(5u, rangeOuterInside->endOffset());
EXPECT_TRUE(rangeOuterSurroundingText->boundaryPointsValid());
EXPECT_EQ(outer, rangeOuterSurroundingText->startContainer());
- EXPECT_EQ(2, rangeOuterSurroundingText->startOffset());
+ EXPECT_EQ(2u, rangeOuterSurroundingText->startOffset());
EXPECT_EQ(outer, rangeOuterSurroundingText->endContainer());
- EXPECT_EQ(4, rangeOuterSurroundingText->endOffset());
+ EXPECT_EQ(4u, rangeOuterSurroundingText->endOffset());
EXPECT_TRUE(rangeInnerLeft->boundaryPointsValid());
EXPECT_EQ(innerLeft, rangeInnerLeft->startContainer());
- EXPECT_EQ(0, rangeInnerLeft->startOffset());
+ EXPECT_EQ(0u, rangeInnerLeft->startOffset());
EXPECT_EQ(innerLeft, rangeInnerLeft->endContainer());
- EXPECT_EQ(1, rangeInnerLeft->endOffset());
+ EXPECT_EQ(1u, rangeInnerLeft->endOffset());
EXPECT_TRUE(rangeInnerRight->boundaryPointsValid());
EXPECT_EQ(innerRight, rangeInnerRight->startContainer());
- EXPECT_EQ(0, rangeInnerRight->startOffset());
+ EXPECT_EQ(0u, rangeInnerRight->startOffset());
EXPECT_EQ(innerRight, rangeInnerRight->endContainer());
- EXPECT_EQ(1, rangeInnerRight->endOffset());
+ EXPECT_EQ(1u, rangeInnerRight->endOffset());
EXPECT_TRUE(rangeFromTextToMiddleOfElement->boundaryPointsValid());
EXPECT_EQ(newText, rangeFromTextToMiddleOfElement->startContainer());
- EXPECT_EQ(3, rangeFromTextToMiddleOfElement->startOffset());
+ EXPECT_EQ(3u, rangeFromTextToMiddleOfElement->startOffset());
EXPECT_EQ(outer, rangeFromTextToMiddleOfElement->endContainer());
- EXPECT_EQ(4, rangeFromTextToMiddleOfElement->endOffset());
+ EXPECT_EQ(4u, rangeFromTextToMiddleOfElement->endOffset());
// StaticRange shouldn't mutate.
EXPECT_EQ(outer, staticRangeOuterOutside->startContainer());

Powered by Google App Engine
This is Rietveld 408576698