Range: node offsets should be unsigned.

third_party/WebKit/Source/core/dom/StaticRangeTest.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/dom/StaticRange.h"
 
 #include "bindings/core/v8/ExceptionState.h"
 #include "core/dom/Element.h"
 #include "core/dom/NodeList.h"
 #include "core/dom/Range.h"
@@ skipping 48 matching lines @@
   Range* range02 = staticRange02->toRange(ASSERT_NO_EXCEPTION);
   Range* range22 = staticRange22->toRange(ASSERT_NO_EXCEPTION);
   Range* range24 = staticRange24->toRange(ASSERT_NO_EXCEPTION);
 
   oldText->splitText(2, ASSERT_NO_EXCEPTION);
   Text* newText = toText(oldText->nextSibling());
 
   // Range should mutate.
   EXPECT_TRUE(range04->boundaryPointsValid());
   EXPECT_EQ(oldText, range04->startContainer());
-  EXPECT_EQ(0, range04->startOffset());
+  EXPECT_EQ(0u, range04->startOffset());
   EXPECT_EQ(newText, range04->endContainer());
-  EXPECT_EQ(2, range04->endOffset());
+  EXPECT_EQ(2u, range04->endOffset());
 
   EXPECT_TRUE(range02->boundaryPointsValid());
   EXPECT_EQ(oldText, range02->startContainer());
-  EXPECT_EQ(0, range02->startOffset());
+  EXPECT_EQ(0u, range02->startOffset());
   EXPECT_EQ(oldText, range02->endContainer());
-  EXPECT_EQ(2, range02->endOffset());
+  EXPECT_EQ(2u, range02->endOffset());
 
   // Our implementation always moves the boundary point at the separation point
   // to the end of the original text node.
   EXPECT_TRUE(range22->boundaryPointsValid());
   EXPECT_EQ(oldText, range22->startContainer());
-  EXPECT_EQ(2, range22->startOffset());
+  EXPECT_EQ(2u, range22->startOffset());
   EXPECT_EQ(oldText, range22->endContainer());
-  EXPECT_EQ(2, range22->endOffset());
+  EXPECT_EQ(2u, range22->endOffset());
 
   EXPECT_TRUE(range24->boundaryPointsValid());
   EXPECT_EQ(oldText, range24->startContainer());
-  EXPECT_EQ(2, range24->startOffset());
+  EXPECT_EQ(2u, range24->startOffset());
   EXPECT_EQ(newText, range24->endContainer());
-  EXPECT_EQ(2, range24->endOffset());
+  EXPECT_EQ(2u, range24->endOffset());
 
   // StaticRange shouldn't mutate.
   EXPECT_EQ(oldText, staticRange04->startContainer());
   EXPECT_EQ(0, staticRange04->startOffset());
   EXPECT_EQ(oldText, staticRange04->endContainer());
   EXPECT_EQ(4, staticRange04->endOffset());
 
   EXPECT_EQ(oldText, staticRange02->startContainer());
   EXPECT_EQ(0, staticRange02->startOffset());
   EXPECT_EQ(oldText, staticRange02->endContainer());
@@ skipping 45 matching lines @@
   Range* rangeInnerRight = staticRangeInnerRight->toRange(ASSERT_NO_EXCEPTION);
   Range* rangeFromTextToMiddleOfElement =
       staticRangeFromTextToMiddleOfElement->toRange(ASSERT_NO_EXCEPTION);
 
   oldText->splitText(3, ASSERT_NO_EXCEPTION);
   Text* newText = toText(oldText->nextSibling());
 
   // Range should mutate.
   EXPECT_TRUE(rangeOuterOutside->boundaryPointsValid());
   EXPECT_EQ(outer, rangeOuterOutside->startContainer());
-  EXPECT_EQ(0, rangeOuterOutside->startOffset());
+  EXPECT_EQ(0u, rangeOuterOutside->startOffset());
   EXPECT_EQ(outer, rangeOuterOutside->endContainer());
-  EXPECT_EQ(6,
+  EXPECT_EQ(6u,
             rangeOuterOutside
                 ->endOffset());  // Increased by 1 since a new node is inserted.
 
   EXPECT_TRUE(rangeOuterInside->boundaryPointsValid());
   EXPECT_EQ(outer, rangeOuterInside->startContainer());
-  EXPECT_EQ(1, rangeOuterInside->startOffset());
+  EXPECT_EQ(1u, rangeOuterInside->startOffset());
   EXPECT_EQ(outer, rangeOuterInside->endContainer());
-  EXPECT_EQ(5, rangeOuterInside->endOffset());
+  EXPECT_EQ(5u, rangeOuterInside->endOffset());
 
   EXPECT_TRUE(rangeOuterSurroundingText->boundaryPointsValid());
   EXPECT_EQ(outer, rangeOuterSurroundingText->startContainer());
-  EXPECT_EQ(2, rangeOuterSurroundingText->startOffset());
+  EXPECT_EQ(2u, rangeOuterSurroundingText->startOffset());
   EXPECT_EQ(outer, rangeOuterSurroundingText->endContainer());
-  EXPECT_EQ(4, rangeOuterSurroundingText->endOffset());
+  EXPECT_EQ(4u, rangeOuterSurroundingText->endOffset());
 
   EXPECT_TRUE(rangeInnerLeft->boundaryPointsValid());
   EXPECT_EQ(innerLeft, rangeInnerLeft->startContainer());
-  EXPECT_EQ(0, rangeInnerLeft->startOffset());
+  EXPECT_EQ(0u, rangeInnerLeft->startOffset());
   EXPECT_EQ(innerLeft, rangeInnerLeft->endContainer());
-  EXPECT_EQ(1, rangeInnerLeft->endOffset());
+  EXPECT_EQ(1u, rangeInnerLeft->endOffset());
 
   EXPECT_TRUE(rangeInnerRight->boundaryPointsValid());
   EXPECT_EQ(innerRight, rangeInnerRight->startContainer());
-  EXPECT_EQ(0, rangeInnerRight->startOffset());
+  EXPECT_EQ(0u, rangeInnerRight->startOffset());
   EXPECT_EQ(innerRight, rangeInnerRight->endContainer());
-  EXPECT_EQ(1, rangeInnerRight->endOffset());
+  EXPECT_EQ(1u, rangeInnerRight->endOffset());
 
   EXPECT_TRUE(rangeFromTextToMiddleOfElement->boundaryPointsValid());
   EXPECT_EQ(newText, rangeFromTextToMiddleOfElement->startContainer());
-  EXPECT_EQ(3, rangeFromTextToMiddleOfElement->startOffset());
+  EXPECT_EQ(3u, rangeFromTextToMiddleOfElement->startOffset());
   EXPECT_EQ(outer, rangeFromTextToMiddleOfElement->endContainer());
-  EXPECT_EQ(4, rangeFromTextToMiddleOfElement->endOffset());
+  EXPECT_EQ(4u, rangeFromTextToMiddleOfElement->endOffset());
 
   // StaticRange shouldn't mutate.
   EXPECT_EQ(outer, staticRangeOuterOutside->startContainer());
   EXPECT_EQ(0, staticRangeOuterOutside->startOffset());
   EXPECT_EQ(outer, staticRangeOuterOutside->endContainer());
   EXPECT_EQ(5, staticRangeOuterOutside->endOffset());
 
   EXPECT_EQ(outer, staticRangeOuterInside->startContainer());
   EXPECT_EQ(1, staticRangeOuterInside->startOffset());
   EXPECT_EQ(outer, staticRangeOuterInside->endContainer());
@@ skipping 37 matching lines @@
   EXPECT_EQ(oldText, staticRange04->endContainer());
   EXPECT_EQ(4, staticRange04->endOffset());
 
   // Invalid StaticRange.
   DummyExceptionStateForTesting exceptionState;
   staticRange04->toRange(exceptionState);
   EXPECT_TRUE(exceptionState.hadException());
 }
 
 }  // namespace blink