Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 2701413002: Revert of [wasm] Embedder can control what buffers wasm compilation works on. (Closed)

Created:
3 years, 10 months ago by Michael Hablich
Modified:
3 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [wasm] Embedder can control what buffers wasm compilation works on. (patchset #3 id:60001 of https://codereview.chromium.org/2699843003/ ) Reason for revert: Introduces a new test failure/flake: https://build.chromium.org/p/client.v8/builders/V8%20Linux/builds/16427 Original issue's description: > [wasm] Embedder can control what buffers wasm compilation works on. > > Two controls, one for instantiation and one for compilation. They allow > the embedder (e.g. Chrome) check properties of the parameters of those > two operations, and decide if they are allowed to continue. > > For example, Chrome may now decline compilation of certain size buffers, > in synchronous cases; same for instantiation (where the buffer size > refers to the size of the buffer containing wasm wire bytes) > > BUG=v8:5981 > > Review-Url: https://codereview.chromium.org/2699843003 > Cr-Commit-Position: refs/heads/master@{#43295} > Committed: https://chromium.googlesource.com/v8/v8/+/d9bc0ffb16e633d52d7bcfd547a6125f0e4dfb87 TBR=bradnelson@chromium.org,titzer@chromium.org,mtrofin@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=v8:5981 Review-Url: https://codereview.chromium.org/2701413002 Cr-Commit-Position: refs/heads/master@{#43303} Committed: https://chromium.googlesource.com/v8/v8/+/1bbbfb42d5e439596c8cae7d12b2896d1f5c01df

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -207 lines) Patch
M include/v8.h View 2 chunks +0 lines, -22 lines 0 comments Download
M src/api.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M src/isolate.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/runtime/runtime-test.cc View 2 chunks +0 lines, -40 lines 0 comments Download
M src/wasm/wasm-js.cc View 8 chunks +9 lines, -30 lines 0 comments Download
D test/mjsunit/wasm/test-wasm-compilation-control.js View 1 chunk +0 lines, -101 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Michael Hablich
Created Revert of [wasm] Embedder can control what buffers wasm compilation works on.
3 years, 10 months ago (2017-02-20 07:29:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2701413002/1
3 years, 10 months ago (2017-02-20 07:29:41 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-20 08:01:10 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/1bbbfb42d5e439596c8cae7d12b2896d1f5...

Powered by Google App Engine
This is Rietveld 408576698