Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1436)

Unified Diff: src/runtime/runtime-test.cc

Issue 2701413002: Revert of [wasm] Embedder can control what buffers wasm compilation works on. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/runtime/runtime.h ('k') | src/wasm/wasm-js.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/runtime/runtime-test.cc
diff --git a/src/runtime/runtime-test.cc b/src/runtime/runtime-test.cc
index be68f72cf6c93bca92d128e0d0ad8eccceb64ea7..3185ee07d17f109d9a49094c0d5fcb6be0dbc63c 100644
--- a/src/runtime/runtime-test.cc
+++ b/src/runtime/runtime-test.cc
@@ -18,27 +18,6 @@
#include "src/snapshot/natives.h"
#include "src/wasm/wasm-module.h"
#include "src/wasm/wasm-objects.h"
-
-namespace {
-struct WasmCompileControls {
- uint32_t MaxWasmBufferSize = std::numeric_limits<uint32_t>::max();
- bool AllowAnySizeForAsync = true;
-} g_WasmCompileControls;
-
-bool IsWasmCompileAllowed(v8::Local<v8::Value> value, bool is_async) {
- return (is_async && g_WasmCompileControls.AllowAnySizeForAsync) ||
- (v8::Local<v8::ArrayBuffer>::Cast(value)->ByteLength() <=
- g_WasmCompileControls.MaxWasmBufferSize);
-}
-
-// Use the compile controls for instantiation, too
-bool IsWasmInstantiateAllowed(v8::Local<v8::WasmCompiledModule> module,
- v8::Local<v8::Value> ffi, bool is_async) {
- return (is_async && g_WasmCompileControls.AllowAnySizeForAsync) ||
- (static_cast<uint32_t>(module->GetWasmWireBytes()->Length()) <=
- g_WasmCompileControls.MaxWasmBufferSize);
-}
-} // namespace
namespace v8 {
namespace internal {
@@ -450,25 +429,6 @@
return isolate->heap()->ToBoolean(count == 1);
}
-RUNTIME_FUNCTION(Runtime_SetWasmCompileControls) {
- HandleScope scope(isolate);
- CHECK(args.length() == 2);
- CONVERT_ARG_HANDLE_CHECKED(Smi, block_size, 0);
- CONVERT_BOOLEAN_ARG_CHECKED(allow_async, 1);
- g_WasmCompileControls.AllowAnySizeForAsync = allow_async;
- g_WasmCompileControls.MaxWasmBufferSize =
- static_cast<uint32_t>(block_size->value());
- isolate->set_allow_wasm_compile_callback(IsWasmCompileAllowed);
- return isolate->heap()->undefined_value();
-}
-
-RUNTIME_FUNCTION(Runtime_SetWasmInstantiateControls) {
- HandleScope scope(isolate);
- CHECK(args.length() == 0);
- isolate->set_allow_wasm_instantiate_callback(IsWasmInstantiateAllowed);
- return isolate->heap()->undefined_value();
-}
-
RUNTIME_FUNCTION(Runtime_NotifyContextDisposed) {
HandleScope scope(isolate);
DCHECK_EQ(0, args.length());
« no previous file with comments | « src/runtime/runtime.h ('k') | src/wasm/wasm-js.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698