Let padding change always trigger layout and full paint invalidation

Let padding change always trigger layout and full paint invalidation

Previously we when padding changed, we marked for layout only, and
during paint invalidation we checked for content box change if anything
depends on the content box. This required us to save the previous
content box for box-sizing:border-box style. Based on stat on 10k
top sites, 12% of all LayoutBoxes have box-sizing:border-box style.

With this CL we will save the previous content box when any background
layer uses it. Less than 0.36% of LayoutBoxes need it.

This reduces a lot of hash map accesses during paint invalidation and
simplifies code, with a drawback that we'll fully invalidate on any
padding change even if it doesn't change visual result (which seems
special).

BUG=685179
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2701103003
Cr-Commit-Position: refs/heads/master@{#452282}
Committed: https://chromium.googlesource.com/chromium/src/+/aaea701d3ab3168a16e45bc5ab59d181a8c871bb

[Xianzhu, 2017-02-18 00:59:58]

Description was changed from

==========
Let padding change always trigger layout and full paint invalidation

Previously we when padding changed, we marked for layout only, and
during paint invalidation we checked for content box change if anything
depends on the content box. This required us to save the previous
content box for box-sizing:border-box style. Based on stat on 10k
top sites, 12% of all LayoutBoxes box-sizing:border-box style.

With this CL we will save the previous content box when any background
layer uses it. Less than 0.36% of LayoutBoxes need it.

This reduces a lot of hash map accesses during paint invalidation and
simplifies code, with a drawback that we'll fully invalidate on any
padding change even if it doesn't change visual result (which seems
special).
==========

to

==========
Let padding change always trigger layout and full paint invalidation

Previously we when padding changed, we marked for layout only, and
during paint invalidation we checked for content box change if anything
depends on the content box. This required us to save the previous
content box for box-sizing:border-box style. Based on stat on 10k
top sites, 12% of all LayoutBoxes box-sizing:border-box style.

With this CL we will save the previous content box when any background
layer uses it. Less than 0.36% of LayoutBoxes need it.

This reduces a lot of hash map accesses during paint invalidation and
simplifies code, with a drawback that we'll fully invalidate on any
padding change even if it doesn't change visual result (which seems
special).
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2017-02-18 01:00:01]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-18 01:00:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-18 03:02:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-18 03:02:53]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[Xianzhu, 2017-02-18 18:31:57]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-18 18:32:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-18 20:03:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-18 20:03:21]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Xianzhu, 2017-02-21 17:11:13]

wangxianzhu@chromium.org changed reviewers:
+ pdr@chromium.org

[Xianzhu, 2017-02-21 17:11:14]

This is the first followup of https://codereview.chromium.org/2695593005/.

[Xianzhu, 2017-02-21 17:16:24]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[Xianzhu, 2017-02-21 17:16:51]

On 2017/02/21 17:11:14, Xianzhu wrote:
> This is the first followup of https://codereview.chromium.org/2695593005/.

Correction: This is the first followup of
https://codereview.chromium.org/2689213013/.

[commit-bot: I haz the power, 2017-02-21 17:16:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2017-02-21 17:51:56]

Description was changed from

==========
Let padding change always trigger layout and full paint invalidation

Previously we when padding changed, we marked for layout only, and
during paint invalidation we checked for content box change if anything
depends on the content box. This required us to save the previous
content box for box-sizing:border-box style. Based on stat on 10k
top sites, 12% of all LayoutBoxes box-sizing:border-box style.

With this CL we will save the previous content box when any background
layer uses it. Less than 0.36% of LayoutBoxes need it.

This reduces a lot of hash map accesses during paint invalidation and
simplifies code, with a drawback that we'll fully invalidate on any
padding change even if it doesn't change visual result (which seems
special).
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Let padding change always trigger layout and full paint invalidation

Previously we when padding changed, we marked for layout only, and
during paint invalidation we checked for content box change if anything
depends on the content box. This required us to save the previous
content box for box-sizing:border-box style. Based on stat on 10k
top sites, 12% of all LayoutBoxes box-sizing:border-box style.

With this CL we will save the previous content box when any background
layer uses it. Less than 0.36% of LayoutBoxes need it.

This reduces a lot of hash map accesses during paint invalidation and
simplifies code, with a drawback that we'll fully invalidate on any
padding change even if it doesn't change visual result (which seems
special).

BUG=685179
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[commit-bot: I haz the power, 2017-02-21 19:04:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 19:04:51]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Xianzhu, 2017-02-22 21:34:01]

Description was changed from

==========
Let padding change always trigger layout and full paint invalidation

Previously we when padding changed, we marked for layout only, and
during paint invalidation we checked for content box change if anything
depends on the content box. This required us to save the previous
content box for box-sizing:border-box style. Based on stat on 10k
top sites, 12% of all LayoutBoxes box-sizing:border-box style.

With this CL we will save the previous content box when any background
layer uses it. Less than 0.36% of LayoutBoxes need it.

This reduces a lot of hash map accesses during paint invalidation and
simplifies code, with a drawback that we'll fully invalidate on any
padding change even if it doesn't change visual result (which seems
special).

BUG=685179
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Let padding change always trigger layout and full paint invalidation

Previously we when padding changed, we marked for layout only, and
during paint invalidation we checked for content box change if anything
depends on the content box. This required us to save the previous
content box for box-sizing:border-box style. Based on stat on 10k
top sites, 12% of all LayoutBoxes have box-sizing:border-box style.

With this CL we will save the previous content box when any background
layer uses it. Less than 0.36% of LayoutBoxes need it.

This reduces a lot of hash map accesses during paint invalidation and
simplifies code, with a drawback that we'll fully invalidate on any
padding change even if it doesn't change visual result (which seems
special).

BUG=685179
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2017-02-22 21:35:57]

https://codereview.chromium.org/2707073002/ depends on this CL. Without this CL,
that CL will increase percentage of LayoutBoxes having LayoutBox::m_rareData to
12%.

[pdr., 2017-02-22 21:39:26]

On 2017/02/22 at 21:35:57, wangxianzhu wrote:
> https://codereview.chromium.org/2707073002/ depends on this CL. Without this
CL, that CL will increase percentage of LayoutBoxes having LayoutBox::m_rareData
to 12%.

LGTM

(sorry about the slow review, took a vacation yesterday)

[Xianzhu, 2017-02-22 21:41:01]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2017-02-22 21:41:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 23:53:15]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487799661724810,
"parent_rev": "6157021217dd1922d6f5dcc8fd00b6e36bbb3a32", "commit_rev":
"aaea701d3ab3168a16e45bc5ab59d181a8c871bb"}

[commit-bot: I haz the power, 2017-02-22 23:53:48]

Description was changed from

==========
Let padding change always trigger layout and full paint invalidation

Previously we when padding changed, we marked for layout only, and
during paint invalidation we checked for content box change if anything
depends on the content box. This required us to save the previous
content box for box-sizing:border-box style. Based on stat on 10k
top sites, 12% of all LayoutBoxes have box-sizing:border-box style.

With this CL we will save the previous content box when any background
layer uses it. Less than 0.36% of LayoutBoxes need it.

This reduces a lot of hash map accesses during paint invalidation and
simplifies code, with a drawback that we'll fully invalidate on any
padding change even if it doesn't change visual result (which seems
special).

BUG=685179
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Let padding change always trigger layout and full paint invalidation

Previously we when padding changed, we marked for layout only, and
during paint invalidation we checked for content box change if anything
depends on the content box. This required us to save the previous
content box for box-sizing:border-box style. Based on stat on 10k
top sites, 12% of all LayoutBoxes have box-sizing:border-box style.

With this CL we will save the previous content box when any background
layer uses it. Less than 0.36% of LayoutBoxes need it.

This reduces a lot of hash map accesses during paint invalidation and
simplifies code, with a drawback that we'll fully invalidate on any
padding change even if it doesn't change visual result (which seems
special).

BUG=685179
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2701103003
Cr-Commit-Position: refs/heads/master@{#452282}
Committed:
https://chromium.googlesource.com/chromium/src/+/aaea701d3ab3168a16e45bc5ab59...
==========

[commit-bot: I haz the power, 2017-02-22 23:53:50]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/aaea701d3ab3168a16e45bc5ab59...