Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(649)

Unified Diff: third_party/WebKit/Source/core/style/ComputedStyle.cpp

Issue 2701103003: Let padding change always trigger layout and full paint invalidation (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/paint/BoxPaintInvalidator.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/style/ComputedStyle.cpp
diff --git a/third_party/WebKit/Source/core/style/ComputedStyle.cpp b/third_party/WebKit/Source/core/style/ComputedStyle.cpp
index 08720ae4b90cfe764ad1910260a44adf9e7d3fff..e2f97ba2fa332c0e8250d38a1ed1b37ddbc91581 100644
--- a/third_party/WebKit/Source/core/style/ComputedStyle.cpp
+++ b/third_party/WebKit/Source/core/style/ComputedStyle.cpp
@@ -638,6 +638,9 @@ bool ComputedStyle::diffNeedsFullLayoutAndPaintInvalidation(
borderBottomWidth() != other.borderBottomWidth() ||
borderRightWidth() != other.borderRightWidth())
return true;
+
+ if (m_surround->padding != other.m_surround->padding)
+ return true;
}
if (m_rareNonInheritedData.get() != other.m_rareNonInheritedData.get()) {
@@ -882,11 +885,6 @@ bool ComputedStyle::diffNeedsFullLayout(const ComputedStyle& other) const {
position() != other.position())
return true;
- if (m_surround.get() != other.m_surround.get()) {
- if (m_surround->padding != other.m_surround->padding)
- return true;
- }
-
if (m_rareNonInheritedData.get() != other.m_rareNonInheritedData.get()) {
if (m_rareNonInheritedData->m_alignContent !=
other.m_rareNonInheritedData->m_alignContent ||
« no previous file with comments | « third_party/WebKit/Source/core/paint/BoxPaintInvalidator.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698