Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2700983003: Revert of WebUI: Vulcanize MD Settings at compile time. (Closed)

Created:
3 years, 10 months ago by mikecase (-- gone --)
Modified:
3 years, 10 months ago
Reviewers:
Nico, Dan Beam, dpapad
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, oshima+watch_chromium.org, stevenjb
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of WebUI: Vulcanize MD Settings at compile time. (patchset #20 id:440001 of https://codereview.chromium.org/2573943002/ ) Reason for revert: Causing compilation failures on Android Perf bots. See crbug/693619 Original issue's description: > WebUI: Vulcanize MD Settings at compile time. > > BUG=673825 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation > > Review-Url: https://codereview.chromium.org/2573943002 > Cr-Original-Commit-Position: refs/heads/master@{#450285} > Committed: https://chromium.googlesource.com/chromium/src/+/e45268fb9d6c1c9c5a57617f6d16e4795c349d69 > Review-Url: https://codereview.chromium.org/2573943002 > Cr-Commit-Position: refs/heads/master@{#451275} > Committed: https://chromium.googlesource.com/chromium/src/+/29db19d0c973a8990283ec4b81111db5bdb8d2de TBR=dbeam@chromium.org,thakis@chromium.org,dpapad@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=673825 Review-Url: https://codereview.chromium.org/2700983003 Cr-Commit-Position: refs/heads/master@{#451333} Committed: https://chromium.googlesource.com/chromium/src/+/14f051ba2a0c49946e279d0beaaef33f6287a7ed

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -84 lines) Patch
M chrome/browser/resources/BUILD.gn View 1 chunk +1 line, -12 lines 0 comments Download
D chrome/browser/resources/settings/BUILD.gn View 1 chunk +0 lines, -31 lines 0 comments Download
M chrome/browser/resources/settings/about_page/about_page.html View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/resources/settings/languages_page/languages_page.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/settings.html View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/settings_resources.grd View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/browser/resources/settings/settings_resources_vulcanized.grd View 1 chunk +0 lines, -19 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_ui.cc View 1 chunk +2 lines, -8 lines 0 comments Download
M tools/gritsettings/resource_ids View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/webui/resources/cr_elements/icons.html View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
mikecase (-- gone --)
Created Revert of WebUI: Vulcanize MD Settings at compile time.
3 years, 10 months ago (2017-02-17 17:41:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2700983003/1
3 years, 10 months ago (2017-02-17 17:42:19 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-17 17:43:49 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/14f051ba2a0c49946e279d0beaae...

Powered by Google App Engine
This is Rietveld 408576698