Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 2700943004: [TTS] Add server control from a field_trial param. (Closed)

Created:
3 years, 10 months ago by Donn Denman
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

[TTS] Add server control from a field_trial param. Add support to set the contextual cards integration version explictly from a field trial param. This will let us control a server-side feature from the field trial config and evaluate client usage differences. BUG=692351 Review-Url: https://codereview.chromium.org/2697513005 Cr-Commit-Position: refs/heads/master@{#450845} (cherry picked from commit 917adcfaa04e622273c5a64694fa578e03ac58ff) Review-Url: https://codereview.chromium.org/2700943004 . Cr-Commit-Position: refs/branch-heads/2987@{#576} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/83cfdcf158a2ce8f9efa5ad68a69dd2e4455cc9e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -8 lines) Patch
M chrome/browser/android/contextualsearch/contextual_search_delegate.cc View 2 chunks +2 lines, -7 lines 0 comments Download
M chrome/browser/android/contextualsearch/contextual_search_field_trial.h View 2 chunks +12 lines, -0 lines 0 comments Download
M chrome/browser/android/contextualsearch/contextual_search_field_trial.cc View 3 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
Donn Denman
3 years, 10 months ago (2017-02-17 17:35:34 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
83cfdcf158a2ce8f9efa5ad68a69dd2e4455cc9e.

Powered by Google App Engine
This is Rietveld 408576698