Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 2697513005: [TTS] Add server control from a field_trial param. (Closed)

Created:
3 years, 10 months ago by Donn Denman
Modified:
3 years, 10 months ago
Reviewers:
Theresa
CC:
chromium-reviews, twellington+watch_chromium.org, donnd+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[TTS] Add server control from a field_trial param. Add support to set the contextual cards integration version explictly from a field trial param. This will let us control a server-side feature from the field trial config and evaluate client usage differences. BUG=692351 Review-Url: https://codereview.chromium.org/2697513005 Cr-Commit-Position: refs/heads/master@{#450845} Committed: https://chromium.googlesource.com/chromium/src/+/917adcfaa04e622273c5a64694fa578e03ac58ff

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -8 lines) Patch
M chrome/browser/android/contextualsearch/contextual_search_delegate.cc View 2 chunks +2 lines, -7 lines 0 comments Download
M chrome/browser/android/contextualsearch/contextual_search_field_trial.h View 2 chunks +12 lines, -0 lines 0 comments Download
M chrome/browser/android/contextualsearch/contextual_search_field_trial.cc View 3 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
Donn Denman
Theresa, PTAL.
3 years, 10 months ago (2017-02-15 17:20:59 UTC) #3
Donn Denman
On 2017/02/15 17:20:59, Donn Denman wrote: > Theresa, PTAL. Theresa, Friendly ping since we want ...
3 years, 10 months ago (2017-02-15 23:07:12 UTC) #7
Donn Denman
On 2017/02/15 23:07:12, Donn Denman wrote: > On 2017/02/15 17:20:59, Donn Denman wrote: > > ...
3 years, 10 months ago (2017-02-15 23:09:34 UTC) #8
Theresa
lgtm
3 years, 10 months ago (2017-02-15 23:15:49 UTC) #9
Donn Denman
On 2017/02/15 23:15:49, Theresa wrote: > lgtm Thanks for all the help on this one ...
3 years, 10 months ago (2017-02-15 23:17:29 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2697513005/1
3 years, 10 months ago (2017-02-15 23:17:54 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-16 00:48:48 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/917adcfaa04e622273c5a64694fa...

Powered by Google App Engine
This is Rietveld 408576698