Chromium Code Reviews
Help | Chromium Project | Sign in
(11)

Issue 2700943003: Invalidate custom pseudo elements for RuleSet invalidations. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months ago by rune
Modified:
2 months ago
Reviewers:
Eric Willigers
CC:
chromium-reviews, blink-reviews-style_chromium.org, blink-reviews-css, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Invalidate custom pseudo elements for RuleSet invalidations. When we have selectors containing custom pseudo elements matching elements inside the UA shadow, and no id, class, or attribute selectors present, do like we do for type selectors and invalidate as part of an invalidation set scheduled on the root node of the tree scope for RuleSet invalidations. We utilize the same invalidation set as for type invalidations and mark it as invalidating custom pseudo elements as well as marking it as tree-boundary-crossing to allow drilling into the UA shadow. This means we will traverse into all shadow sub-trees, but it should at least be better than the existing recalc all behavior. The full recalc for custom pseudo elements caused a full recalc for one of the stylesheets on facebook.com. R=ericwilligers@chromium.org BUG=680549 Review-Url: https://codereview.chromium.org/2700943003 Cr-Commit-Position: refs/heads/master@{#451578} Committed: https://chromium.googlesource.com/chromium/src/+/248934089f7a250a94842e1c3059167d704e72fd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -15 lines) Patch
M third_party/WebKit/LayoutTests/fast/css/invalidation/sheet-ruleset-invalidation.html View 2 chunks +22 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/RuleFeature.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/RuleFeature.cpp View 2 chunks +16 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/css/RuleFeatureSetTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngineTest.cpp View 1 chunk +17 lines, -0 lines 0 comments Download
Trybot results:  mac_chromium_rel_ng   linux_chromium_chromeos_ozone_rel_ng   android_clang_dbg_recipe   linux_chromium_chromeos_rel_ng   android_arm64_dbg_recipe   win_chromium_compile_dbg_ng   ios-device   android_compile_dbg   chromeos_daisy_chromium_compile_only_ng   linux_chromium_rel_ng   linux_android_rel_ng   linux_chromium_tsan_rel_ng   win_clang   ios-device-xcode-clang   android_n5x_swarming_rel   win_chromium_rel_ng   chromium_presubmit   mac_chromium_rel_ng   win_chromium_x64_rel_ng   ios-simulator-xcode-clang   chromeos_amd64-generic_chromium_compile_only_ng   mac_chromium_compile_dbg_ng   linux_chromium_chromeos_ozone_rel_ng   cast_shell_android   android_cronet   cast_shell_linux   linux_chromium_asan_rel_ng   ios-simulator   linux_chromium_compile_dbg_ng   linux_chromium_chromeos_rel_ng   android_arm64_dbg_recipe   win_chromium_rel_ng   linux_chromium_chromeos_rel_ng   win_chromium_x64_rel_ng   chromium_presubmit   linux_android_rel_ng   linux_chromium_chromeos_ozone_rel_ng   linux_chromium_rel_ng   cast_shell_android   win_clang   win_chromium_compile_dbg_ng   linux_chromium_tsan_rel_ng   cast_shell_linux   ios-device-xcode-clang   android_clang_dbg_recipe   linux_chromium_asan_rel_ng   linux_chromium_compile_dbg_ng   mac_chromium_rel_ng   chromeos_daisy_chromium_compile_only_ng   ios-simulator-xcode-clang   chromeos_amd64-generic_chromium_compile_only_ng   android_compile_dbg   android_cronet   ios-device   android_n5x_swarming_rel   mac_chromium_compile_dbg_ng   ios-simulator 
Commit queue not available (can’t edit this change).

Depends on Patchset:

Messages

Total messages: 11 (7 generated)
rune
ptal
2 months ago (2017-02-17 13:38:45 UTC) #3
Eric Willigers
lgtm
2 months ago (2017-02-20 02:00:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2700943003/1
2 months ago (2017-02-20 06:06:08 UTC) #8
commit-bot: I haz the power
2 months ago (2017-02-20 08:04:46 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/248934089f7a250a94842e1c3059...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cc6ac46