Schedule a type selector invalidation set for RuleSet invalidations.

Schedule a type selector invalidation set for RuleSet invalidations.

We marked all elements which had a selector in the tagRules bucket for
style recalc for RuleSet invalidations. That means we would recalculate
style for all spans if we added a stylesheet containing a rule with an
"#id span" selector (but not for "#id span.class" as that ends up in
the classRules bucket).

Instead, use an invalidation set containing only tag names for the
selectors where there are no ids, classes, or attribute selectors, and
which have a type selector in the rightmost compound. This means that
"#id span" will not add "span" to that set, but "span" and "div span"
will. "div span" will not add "div", and "div *" will cause a full
scope recalc. In order to support invalidation for those, we would have
had to have one invalidation set for each tag name instead of a single
descendant invalidation set for all.

RuleSet invalidations schedule this typeRuleInvalidationSet on the root
of the TreeScope When doing ruleset invalidations.

BUG=680549
Review-Url: https://codereview.chromium.org/2703643003
Cr-Commit-Position: refs/heads/master@{#451488}
Committed: https://chromium.googlesource.com/chromium/src/+/a04a994fb4146b480a2fb4c0505679fc1e1d857a

[rune, 2017-02-16 21:31:47]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-16 21:33:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rune, 2017-02-16 23:31:09]

rune@opera.com changed reviewers:
+ ericwilligers@chromium.org, sashab@chromium.org

[rune, 2017-02-16 23:31:10]

ptal

[commit-bot: I haz the power, 2017-02-16 23:58:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 23:58:17]

Dry run: This issue passed the CQ dry run.

[Eric Willigers, 2017-02-17 00:26:12]

Do we have layout tests that cover the relevant invalidations when the set of
style sheets changes?

[rune, 2017-02-17 00:48:01]

On 2017/02/17 00:26:12, Eric Willigers wrote:
> Do we have layout tests that cover the relevant invalidations when the set of
> style sheets changes?

I can add more cases to fast/css/invalidation/sheet-ruleset-invalidation.html

[rune, 2017-02-17 10:51:46]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 10:52:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rune, 2017-02-17 10:52:18]

On 2017/02/17 00:48:01, rune wrote:
> On 2017/02/17 00:26:12, Eric Willigers wrote:
> > Do we have layout tests that cover the relevant invalidations when the set
of
> > style sheets changes?
> 
> I can add more cases to fast/css/invalidation/sheet-ruleset-invalidation.html

Done.

[commit-bot: I haz the power, 2017-02-17 12:20:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 12:20:52]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[rune, 2017-02-17 13:38:12]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 13:38:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 14:47:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 14:47:20]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Eric Willigers, 2017-02-17 20:54:37]

lgtm

[rune, 2017-02-18 18:22:17]

The CQ bit was checked by rune@opera.com

[commit-bot: I haz the power, 2017-02-18 18:22:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-18 19:53:23]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1487442137678170,
"parent_rev": "c1c4c42801154e21fa00c8ce5fc0c4f462038fd5", "commit_rev":
"a04a994fb4146b480a2fb4c0505679fc1e1d857a"}

[commit-bot: I haz the power, 2017-02-18 19:53:58]

Description was changed from

==========
Schedule a type selector invalidation set for RuleSet invalidations.

We marked all elements which had a selector in the tagRules bucket for
style recalc for RuleSet invalidations. That means we would recalculate
style for all spans if we added a stylesheet containing a rule with an
"#id span" selector (but not for "#id span.class" as that ends up in
the classRules bucket).

Instead, use an invalidation set containing only tag names for the
selectors where there are no ids, classes, or attribute selectors, and
which have a type selector in the rightmost compound. This means that
"#id span" will not add "span" to that set, but "span" and "div span"
will. "div span" will not add "div", and "div *" will cause a full
scope recalc. In order to support invalidation for those, we would have
had to have one invalidation set for each tag name instead of a single
descendant invalidation set for all.

RuleSet invalidations schedule this typeRuleInvalidationSet on the root
of the TreeScope When doing ruleset invalidations.

BUG=680549
==========

to

==========
Schedule a type selector invalidation set for RuleSet invalidations.

We marked all elements which had a selector in the tagRules bucket for
style recalc for RuleSet invalidations. That means we would recalculate
style for all spans if we added a stylesheet containing a rule with an
"#id span" selector (but not for "#id span.class" as that ends up in
the classRules bucket).

Instead, use an invalidation set containing only tag names for the
selectors where there are no ids, classes, or attribute selectors, and
which have a type selector in the rightmost compound. This means that
"#id span" will not add "span" to that set, but "span" and "div span"
will. "div span" will not add "div", and "div *" will cause a full
scope recalc. In order to support invalidation for those, we would have
had to have one invalidation set for each tag name instead of a single
descendant invalidation set for all.

RuleSet invalidations schedule this typeRuleInvalidationSet on the root
of the TreeScope When doing ruleset invalidations.

BUG=680549

Review-Url: https://codereview.chromium.org/2703643003
Cr-Commit-Position: refs/heads/master@{#451488}
Committed:
https://chromium.googlesource.com/chromium/src/+/a04a994fb4146b480a2fb4c05056...
==========

[commit-bot: I haz the power, 2017-02-18 19:53:59]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/a04a994fb4146b480a2fb4c05056...