Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(711)

Issue 2700653002: [Ash MD] Remove pre-MD code from TrayImageItem and subclasses (Closed)

Created:
3 years, 10 months ago by tdanderson
Modified:
3 years, 10 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, sadrul, dtseng+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, oshima+watch_chromium.org, kalyank
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Ash MD] Remove pre-MD code from TrayImageItem and subclasses Remove the pre-MD code and now-unused PNG assets from the TrayImageItem class, its subclasses, and associated default rows in the Ash system menu. BUG=686217, 686256, 687813, 687814, 687815, 687818 TEST=manual, no functional changes Review-Url: https://codereview.chromium.org/2700653002 Cr-Commit-Position: refs/heads/master@{#451392} Committed: https://chromium.googlesource.com/chromium/src/+/d76a3c6165fa6b8d279372c7c4cd5f383d63cecf

Patch Set 1 #

Total comments: 4

Patch Set 2 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -199 lines) Patch
M ash/common/system/chromeos/audio/tray_audio.cc View 2 chunks +1 line, -2 lines 0 comments Download
M ash/common/system/chromeos/tray_caps_lock.cc View 6 chunks +22 lines, -32 lines 0 comments Download
M ash/common/system/chromeos/tray_tracing.cc View 1 4 chunks +10 lines, -20 lines 0 comments Download
M ash/common/system/tray/tray_image_item.h View 1 2 chunks +10 lines, -13 lines 0 comments Download
M ash/common/system/tray/tray_image_item.cc View 1 3 chunks +4 lines, -47 lines 0 comments Download
M ash/common/system/tray_accessibility.cc View 1 3 chunks +2 lines, -12 lines 0 comments Download
M ash/common/system/update/tray_update.cc View 7 chunks +9 lines, -50 lines 0 comments Download
M ash/resources/ash_resources.grd View 1 4 chunks +0 lines, -18 lines 0 comments Download
D ash/resources/default_100_percent/cros/status/status_accessibility_mode.png View Binary file 0 comments Download
D ash/resources/default_100_percent/cros/status/status_auto_rotate_dark.png View Binary file 0 comments Download
D ash/resources/default_100_percent/cros/status/status_auto_rotate_locked.png View Binary file 0 comments Download
D ash/resources/default_100_percent/cros/status/status_auto_rotate_locked_dark.png View Binary file 0 comments Download
D ash/resources/default_100_percent/cros/status/status_capslock.png View Binary file 0 comments Download
D ash/resources/default_100_percent/cros/status/status_capslock_dark.png View Binary file 0 comments Download
D ash/resources/default_100_percent/cros/status/status_tracing.png View Binary file 0 comments Download
D ash/resources/default_100_percent/cros/status/status_update.png View Binary file 0 comments Download
D ash/resources/default_100_percent/cros/status/status_update_dark.png View Binary file 0 comments Download
D ash/resources/default_100_percent/cros/status/status_update_dark_green.png View Binary file 0 comments Download
D ash/resources/default_100_percent/cros/status/status_update_dark_orange.png View Binary file 0 comments Download
D ash/resources/default_100_percent/cros/status/status_update_dark_red.png View Binary file 0 comments Download
D ash/resources/default_100_percent/cros/status/status_update_green.png View Binary file 0 comments Download
D ash/resources/default_100_percent/cros/status/status_update_orange.png View Binary file 0 comments Download
D ash/resources/default_100_percent/cros/status/status_update_red.png View Binary file 0 comments Download
D ash/resources/default_100_percent/cros/status/status_volume_mute.png View Binary file 0 comments Download
D ash/resources/default_200_percent/cros/status/status_accessibility_mode.png View Binary file 0 comments Download
D ash/resources/default_200_percent/cros/status/status_auto_rotate_dark.png View Binary file 0 comments Download
D ash/resources/default_200_percent/cros/status/status_auto_rotate_locked.png View Binary file 0 comments Download
D ash/resources/default_200_percent/cros/status/status_auto_rotate_locked_dark.png View Binary file 0 comments Download
D ash/resources/default_200_percent/cros/status/status_capslock.png View Binary file 0 comments Download
D ash/resources/default_200_percent/cros/status/status_capslock_dark.png View Binary file 0 comments Download
D ash/resources/default_200_percent/cros/status/status_tracing.png View Binary file 0 comments Download
D ash/resources/default_200_percent/cros/status/status_update.png View Binary file 0 comments Download
D ash/resources/default_200_percent/cros/status/status_update_dark.png View Binary file 0 comments Download
D ash/resources/default_200_percent/cros/status/status_update_dark_green.png View Binary file 0 comments Download
D ash/resources/default_200_percent/cros/status/status_update_dark_orange.png View Binary file 0 comments Download
D ash/resources/default_200_percent/cros/status/status_update_dark_red.png View Binary file 0 comments Download
D ash/resources/default_200_percent/cros/status/status_update_green.png View Binary file 0 comments Download
D ash/resources/default_200_percent/cros/status/status_update_orange.png View Binary file 0 comments Download
D ash/resources/default_200_percent/cros/status/status_update_red.png View Binary file 0 comments Download
D ash/resources/default_200_percent/cros/status/status_volume_mute.png View Binary file 0 comments Download
M ash/system/chromeos/rotation/tray_rotation_lock.cc View 1 4 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
tdanderson
Evan, can you please take a look?
3 years, 10 months ago (2017-02-15 23:47:53 UTC) #5
Evan Stade
lgtm https://codereview.chromium.org/2700653002/diff/1/ash/common/system/tray/tray_image_item.h File ash/common/system/tray/tray_image_item.h (right): https://codereview.chromium.org/2700653002/diff/1/ash/common/system/tray/tray_image_item.h#newcode55 ash/common/system/tray/tray_image_item.h:55: const gfx::VectorIcon* icon_ = nullptr; const ref (?) ...
3 years, 10 months ago (2017-02-16 19:53:14 UTC) #8
tdanderson
https://codereview.chromium.org/2700653002/diff/1/ash/common/system/tray/tray_image_item.h File ash/common/system/tray/tray_image_item.h (right): https://codereview.chromium.org/2700653002/diff/1/ash/common/system/tray/tray_image_item.h#newcode55 ash/common/system/tray/tray_image_item.h:55: const gfx::VectorIcon* icon_ = nullptr; On 2017/02/16 19:53:14, Evan ...
3 years, 10 months ago (2017-02-17 20:32:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2700653002/20001
3 years, 10 months ago (2017-02-17 20:33:57 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-17 22:54:02 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d76a3c6165fa6b8d279372c7c4cd...

Powered by Google App Engine
This is Rietveld 408576698