[Ash MD] Remove pre-MD code from TrayImageItem and subclasses

[Ash MD] Remove pre-MD code from TrayImageItem and subclasses

Remove the pre-MD code and now-unused PNG assets
from the TrayImageItem class, its subclasses,
and associated default rows in the Ash system menu.

BUG=686217, 686256, 687813, 687814, 687815, 687818
TEST=manual, no functional changes

Review-Url: https://codereview.chromium.org/2700653002
Cr-Commit-Position: refs/heads/master@{#451392}
Committed: https://chromium.googlesource.com/chromium/src/+/d76a3c6165fa6b8d279372c7c4cd5f383d63cecf

[tdanderson, 2017-02-15 23:39:53]

The CQ bit was checked by tdanderson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-15 23:40:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tdanderson, 2017-02-15 23:47:30]

Description was changed from

==========
[Ash MD] Remove pre-MD code from TrayImageItem and subclasses

Remove the pre-MD code and now-unused PNG assets
from the TrayImageItem class, its subclasses,
and associated default rows in the Ash system menu.

BUG=.
TEST=manual, no functional changes
==========

to

==========
[Ash MD] Remove pre-MD code from TrayImageItem and subclasses

Remove the pre-MD code and now-unused PNG assets
from the TrayImageItem class, its subclasses,
and associated default rows in the Ash system menu.

BUG=686217,686256,687813,687814,687815,687818
TEST=manual, no functional changes
==========

[tdanderson, 2017-02-15 23:47:52]

tdanderson@chromium.org changed reviewers:
+ estade@chromium.org

[tdanderson, 2017-02-15 23:47:53]

Evan, can you please take a look?

[commit-bot: I haz the power, 2017-02-16 01:44:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 01:44:20]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)

[Evan Stade, 2017-02-16 19:53:14]

lgtm

https://codereview.chromium.org/2700653002/diff/1/ash/common/system/tray/tray...
File ash/common/system/tray/tray_image_item.h (right):

https://codereview.chromium.org/2700653002/diff/1/ash/common/system/tray/tray...
ash/common/system/tray/tray_image_item.h:55: const gfx::VectorIcon* icon_ =
nullptr;
const ref (?)

https://codereview.chromium.org/2700653002/diff/1/ash/common/system/tray_acce...
File ash/common/system/tray_accessibility.cc (right):

https://codereview.chromium.org/2700653002/diff/1/ash/common/system/tray_acce...
ash/common/system/tray_accessibility.cc:90:
ui::ResourceBundle::GetSharedInstance().GetLocalizedString(
l10n_util::GetString

[tdanderson, 2017-02-17 20:32:48]

https://codereview.chromium.org/2700653002/diff/1/ash/common/system/tray/tray...
File ash/common/system/tray/tray_image_item.h (right):

https://codereview.chromium.org/2700653002/diff/1/ash/common/system/tray/tray...
ash/common/system/tray/tray_image_item.h:55: const gfx::VectorIcon* icon_ =
nullptr;
On 2017/02/16 19:53:14, Evan Stade wrote:
> const ref (?)

Done.

https://codereview.chromium.org/2700653002/diff/1/ash/common/system/tray_acce...
File ash/common/system/tray_accessibility.cc (right):

https://codereview.chromium.org/2700653002/diff/1/ash/common/system/tray_acce...
ash/common/system/tray_accessibility.cc:90:
ui::ResourceBundle::GetSharedInstance().GetLocalizedString(
On 2017/02/16 19:53:14, Evan Stade wrote:
> l10n_util::GetString

Done.

[tdanderson, 2017-02-17 20:32:58]

The CQ bit was checked by tdanderson@chromium.org

[tdanderson, 2017-02-17 20:32:59]

The patchset sent to the CQ was uploaded after l-g-t-m from estade@chromium.org
Link to the patchset: https://codereview.chromium.org/2700653002/#ps20001
(title: "comments")

[commit-bot: I haz the power, 2017-02-17 20:33:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 22:53:17]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487363578497690,
"parent_rev": "b25fc47b3517d87ea086cea8a6b96a562c2dee01", "commit_rev":
"d76a3c6165fa6b8d279372c7c4cd5f383d63cecf"}

[commit-bot: I haz the power, 2017-02-17 22:54:01]

Description was changed from

==========
[Ash MD] Remove pre-MD code from TrayImageItem and subclasses

Remove the pre-MD code and now-unused PNG assets
from the TrayImageItem class, its subclasses,
and associated default rows in the Ash system menu.

BUG=686217,686256,687813,687814,687815,687818
TEST=manual, no functional changes
==========

to

==========
[Ash MD] Remove pre-MD code from TrayImageItem and subclasses

Remove the pre-MD code and now-unused PNG assets
from the TrayImageItem class, its subclasses,
and associated default rows in the Ash system menu.

BUG=686217,686256,687813,687814,687815,687818
TEST=manual, no functional changes

Review-Url: https://codereview.chromium.org/2700653002
Cr-Commit-Position: refs/heads/master@{#451392}
Committed:
https://chromium.googlesource.com/chromium/src/+/d76a3c6165fa6b8d279372c7c4cd...
==========

[commit-bot: I haz the power, 2017-02-17 22:54:02]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d76a3c6165fa6b8d279372c7c4cd...