Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2700643002:
Increase the NQE cache size from 3 to 10 (Closed)
DescriptionIncrease the NQE cache size from 3 to 10
BUG=692239
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
Review-Url: https://codereview.chromium.org/2700643002
Cr-Commit-Position: refs/heads/master@{#451199}
Committed: https://chromium.googlesource.com/chromium/src/+/d002c65edf2c2fb116ac91eead64cf3bb1b61ed0
Patch Set 1 #
Total comments: 2
Patch Set 2 : added comment #
Messages
Total messages: 24 (17 generated)
Description was changed from ========== Increase the cache size to 10. BUG= ========== to ========== Increase the NQE cache size to 10 from 3 BUG=692239 ==========
Description was changed from ========== Increase the NQE cache size to 10 from 3 BUG=692239 ========== to ========== Increase the NQE cache size to 10 from 3 BUG=692239 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester ==========
tbansal@chromium.org changed reviewers: + ryansturm@chromium.org
ptal. thanks.
The CQ bit was checked by tbansal@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Increase the NQE cache size to 10 from 3 BUG=692239 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester ========== to ========== Increase the NQE cache size from 3 to 10 BUG=692239 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
lgtm
xunjieli@chromium.org changed reviewers: + xunjieli@chromium.org
https://codereview.chromium.org/2700643002/diff/1/net/nqe/network_qualities_p... File net/nqe/network_qualities_prefs_manager.cc (right): https://codereview.chromium.org/2700643002/diff/1/net/nqe/network_qualities_p... net/nqe/network_qualities_prefs_manager.cc:22: static const size_t kMaxCacheSize = 10u; nit: Can you add a comment here on why big an entry is? so we can expect how much disk space it is going to take and whether this impacts startup performance.
xunjieli: ptal. thanks. https://codereview.chromium.org/2700643002/diff/1/net/nqe/network_qualities_p... File net/nqe/network_qualities_prefs_manager.cc (right): https://codereview.chromium.org/2700643002/diff/1/net/nqe/network_qualities_p... net/nqe/network_qualities_prefs_manager.cc:22: static const size_t kMaxCacheSize = 10u; On 2017/02/16 18:59:57, xunjieli wrote: > nit: Can you add a comment here on why big an entry is? so we can expect how > much disk space it is going to take and whether this impacts startup > performance. Done.
The CQ bit was checked by tbansal@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by tbansal@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from ryansturm@chromium.org Link to the patchset: https://codereview.chromium.org/2700643002/#ps20001 (title: "added comment")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487293351859520,
"parent_rev": "0918ae11092a7ee1b278cc1a55259e7d886f156d", "commit_rev":
"d002c65edf2c2fb116ac91eead64cf3bb1b61ed0"}
Message was sent while issue was closed.
Description was changed from ========== Increase the NQE cache size from 3 to 10 BUG=692239 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester ========== to ========== Increase the NQE cache size from 3 to 10 BUG=692239 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2700643002 Cr-Commit-Position: refs/heads/master@{#451199} Committed: https://chromium.googlesource.com/chromium/src/+/d002c65edf2c2fb116ac91eead64... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/d002c65edf2c2fb116ac91eead64... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
