Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(689)

Unified Diff: net/nqe/network_qualities_prefs_manager.cc

Issue 2700643002: Increase the NQE cache size from 3 to 10 (Closed)
Patch Set: added comment Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/nqe/network_qualities_prefs_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/nqe/network_qualities_prefs_manager.cc
diff --git a/net/nqe/network_qualities_prefs_manager.cc b/net/nqe/network_qualities_prefs_manager.cc
index e11abd8574cfa60a76d169ca4b919a64c125b750..82e22c47a4476ce8e18297b78237d454fd043d00 100644
--- a/net/nqe/network_qualities_prefs_manager.cc
+++ b/net/nqe/network_qualities_prefs_manager.cc
@@ -19,7 +19,14 @@ namespace net {
namespace {
// Maximum size of the prefs that hold the qualities of different networks.
-static const size_t kMaxCacheSize = 3u;
+// A single entry in the cache consists of three tuples:
+// (i) SSID or MCCMNC of the network. SSID is at most 32 characters in length
+// (but is typically shorter than that). MCCMNC is at most 6 characters
+// long.
+// (ii) Connection type of the network as reported by network
+// change notifier (an enum).
+// (iii) Effective connection type of the network (an enum).
+static const size_t kMaxCacheSize = 10u;
// Parses |value| into a map of NetworkIDs and CachedNetworkQualities,
// and returns the map.
« no previous file with comments | « no previous file | net/nqe/network_qualities_prefs_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698