Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Issue 2700613002: Reland recording box shadow as main thread scrolling reason with conflict fixed (Closed)

Created:
3 years, 10 months ago by yigu
Modified:
3 years, 10 months ago
Reviewers:
pdr., ajuma
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, dshwang, jchaffraix+rendering, blink-reviews-paint_chromium.org, blink-reviews, cc-bugs_chromium.org, kinuko+watch, bokan
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland with conflict fixed BUG=660907 TEST=StyleRelatedMainThreadScrollingReasonTest.BoxShadowTest CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2700613002 Cr-Commit-Position: refs/heads/master@{#450958} Committed: https://chromium.googlesource.com/chromium/src/+/3d1a8d1c963cae739551639bcec3e4b2e15b9b10

Patch Set 1 #

Patch Set 2 : update test from TEST_F to TEST_P #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -23 lines) Patch
M cc/input/main_thread_scrolling_reason.h View 4 chunks +6 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp View 3 chunks +7 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayer.h View 1 chunk +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayer.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp View 4 chunks +27 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp View 1 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/tests/data/two_scrollable_area.html View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (15 generated)
yigu
Hi Philip, this patch is a reland cl of a previously reverted CL and it ...
3 years, 10 months ago (2017-02-15 20:53:58 UTC) #7
ajuma
On 2017/02/15 20:53:58, yigu wrote: > Hi Philip, this patch is a reland cl of ...
3 years, 10 months ago (2017-02-15 22:36:15 UTC) #12
pdr.
On 2017/02/15 at 22:36:15, ajuma wrote: > On 2017/02/15 20:53:58, yigu wrote: > > Hi ...
3 years, 10 months ago (2017-02-16 04:36:55 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2700613002/20001
3 years, 10 months ago (2017-02-16 14:03:51 UTC) #17
commit-bot: I haz the power
3 years, 10 months ago (2017-02-16 14:41:31 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3d1a8d1c963cae739551639bcec3...

Powered by Google App Engine
This is Rietveld 408576698