Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: cc/input/main_thread_scrolling_reason.h

Issue 2700613002: Reland recording box shadow as main thread scrolling reason with conflict fixed (Closed)
Patch Set: update test from TEST_F to TEST_P Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/input/main_thread_scrolling_reason.h
diff --git a/cc/input/main_thread_scrolling_reason.h b/cc/input/main_thread_scrolling_reason.h
index 899aad868407c165368e50b0303279291b9918e6..a2a02222ad41f073f1a1a4e77377191879c58612 100644
--- a/cc/input/main_thread_scrolling_reason.h
+++ b/cc/input/main_thread_scrolling_reason.h
@@ -41,6 +41,7 @@ struct MainThreadScrollingReason {
kBackgroundNotOpaqueInRectAndLCDText = 1 << 18,
kHasBorderRadius = 1 << 19,
kHasClipRelatedProperty = 1 << 20,
+ kHasBoxShadowFromNonRootLayer = 1 << 21,
// Transient scrolling reasons. These are computed for each scroll begin.
kNonFastScrollableRegion = 1 << 5,
@@ -55,7 +56,7 @@ struct MainThreadScrollingReason {
// New flags should increment this number but it should never be decremented
// because the values are used in UMA histograms. It should also be noted
// that it excludes the kNotScrollingOnMain value.
- kMainThreadScrollingReasonCount = 21,
+ kMainThreadScrollingReasonCount = 22,
};
// Returns true if the given MainThreadScrollingReason can be set by the main
@@ -67,7 +68,8 @@ struct MainThreadScrollingReason {
kScrollbarScrolling | kPageOverlay | kHandlingScrollFromMainThread |
kCustomScrollbarScrolling | kHasOpacityAndLCDText |
kHasTransformAndLCDText | kBackgroundNotOpaqueInRectAndLCDText |
- kHasBorderRadius | kHasClipRelatedProperty;
+ kHasBorderRadius | kHasClipRelatedProperty |
+ kHasBoxShadowFromNonRootLayer;
return (reasons & reasons_set_by_main_thread) == reasons;
}
@@ -125,6 +127,8 @@ struct MainThreadScrollingReason {
tracedValue->AppendString("Has border radius");
if (reasons & MainThreadScrollingReason::kHasClipRelatedProperty)
tracedValue->AppendString("Has clip related property");
+ if (reasons & MainThreadScrollingReason::kHasBoxShadowFromNonRootLayer)
+ tracedValue->AppendString("Has box shadow from non-root layer");
// Transient scrolling reasons.
if (reasons & MainThreadScrollingReason::kNonFastScrollableRegion)
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698