cros: Unify oobe View/Actor naming to just View.

cros: Unify oobe View/Actor naming to just View.

BUG=672142
Review-Url: https://codereview.chromium.org/2700303002
Cr-Commit-Position: refs/heads/master@{#452906}
Committed: https://chromium.googlesource.com/chromium/src/+/eda3863d1963478c04b05d846f3ce34cac5283ee

[jdufault, 2017-02-18 01:20:08]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-18 01:21:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-18 02:33:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-18 02:33:41]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[jdufault, 2017-02-21 18:31:05]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[jdufault, 2017-02-21 18:32:35]

Description was changed from

==========
cros: Unify oobe View/Actor naming to just View.

BUG=
==========

to

==========
cros: Unify oobe View/Actor naming to just View.

BUG=672142
==========

[jdufault, 2017-02-21 18:32:35]

jdufault@chromium.org changed reviewers:
+ alemate@chromium.org

[commit-bot: I haz the power, 2017-02-21 18:32:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jdufault, 2017-02-21 18:36:07]

alemate@ PTAL. There should be no functional change.

[commit-bot: I haz the power, 2017-02-21 21:24:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 21:24:38]

Dry run: This issue passed the CQ dry run.

[Alexander Alekseev, 2017-02-22 00:21:05]

lgtm with nits

PS: you also need an owner for /arc/ .

https://codereview.chromium.org/2700303002/diff/1/chrome/browser/ui/webui/chr...
File chrome/browser/ui/webui/chromeos/login/oobe_ui.h (right):

https://codereview.chromium.org/2700303002/diff/1/chrome/browser/ui/webui/chr...
chrome/browser/ui/webui/chromeos/login/oobe_ui.h:226: TermsOfServiceScreenView*
terms_of_service_screen_actor_ = nullptr;
nit: "_view_" ?

https://codereview.chromium.org/2700303002/diff/1/chrome/browser/ui/webui/chr...
chrome/browser/ui/webui/chromeos/login/oobe_ui.h:227:
ArcTermsOfServiceScreenView* arc_terms_of_service_screen_actor_ = nullptr;
nit: "_view_" ?

https://codereview.chromium.org/2700303002/diff/1/chrome/browser/ui/webui/chr...
File chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc (right):

https://codereview.chromium.org/2700303002/diff/1/chrome/browser/ui/webui/chr...
chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc:293:
CoreOobeView* core_oobe_actor,
nit: view ?

https://codereview.chromium.org/2700303002/diff/1/chrome/browser/ui/webui/chr...
File chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h (right):

https://codereview.chromium.org/2700303002/diff/1/chrome/browser/ui/webui/chr...
chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h:233:
CoreOobeView* core_oobe_actor,
nit: view ?

https://codereview.chromium.org/2700303002/diff/1/chrome/browser/ui/webui/chr...
chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h:470:
CoreOobeView* core_oobe_actor_ = nullptr;
nit: view ?

https://codereview.chromium.org/2700303002/diff/1/chrome/browser/ui/webui/chr...
File chrome/browser/ui/webui/chromeos/login/terms_of_service_screen_handler.cc
(right):

https://codereview.chromium.org/2700303002/diff/1/chrome/browser/ui/webui/chr...
chrome/browser/ui/webui/chromeos/login/terms_of_service_screen_handler.cc:40:
CoreOobeView* core_oobe_actor)
nit: view .

https://codereview.chromium.org/2700303002/diff/1/chrome/browser/ui/webui/chr...
File chrome/browser/ui/webui/chromeos/login/terms_of_service_screen_handler.h
(right):

https://codereview.chromium.org/2700303002/diff/1/chrome/browser/ui/webui/chr...
chrome/browser/ui/webui/chromeos/login/terms_of_service_screen_handler.h:24:
explicit TermsOfServiceScreenHandler(CoreOobeView* core_oobe_actor);
nit: view ?

https://codereview.chromium.org/2700303002/diff/1/chrome/browser/ui/webui/chr...
chrome/browser/ui/webui/chromeos/login/terms_of_service_screen_handler.h:73:
CoreOobeView* core_oobe_actor_ = nullptr;
nit: view_ ?

[jdufault, 2017-02-22 01:01:49]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[jdufault, 2017-02-22 01:02:25]

https://codereview.chromium.org/2700303002/diff/1/chrome/browser/ui/webui/chr...
File chrome/browser/ui/webui/chromeos/login/oobe_ui.h (right):

https://codereview.chromium.org/2700303002/diff/1/chrome/browser/ui/webui/chr...
chrome/browser/ui/webui/chromeos/login/oobe_ui.h:226: TermsOfServiceScreenView*
terms_of_service_screen_actor_ = nullptr;
On 2017/02/22 00:21:05, Alexander Alekseev wrote:
> nit: "_view_" ?

Done.

https://codereview.chromium.org/2700303002/diff/1/chrome/browser/ui/webui/chr...
chrome/browser/ui/webui/chromeos/login/oobe_ui.h:227:
ArcTermsOfServiceScreenView* arc_terms_of_service_screen_actor_ = nullptr;
On 2017/02/22 00:21:05, Alexander Alekseev wrote:
> nit: "_view_" ?

Done.

https://codereview.chromium.org/2700303002/diff/1/chrome/browser/ui/webui/chr...
File chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc (right):

https://codereview.chromium.org/2700303002/diff/1/chrome/browser/ui/webui/chr...
chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc:293:
CoreOobeView* core_oobe_actor,
On 2017/02/22 00:21:05, Alexander Alekseev wrote:
> nit: view ?

Done.

https://codereview.chromium.org/2700303002/diff/1/chrome/browser/ui/webui/chr...
File chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h (right):

https://codereview.chromium.org/2700303002/diff/1/chrome/browser/ui/webui/chr...
chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h:233:
CoreOobeView* core_oobe_actor,
On 2017/02/22 00:21:05, Alexander Alekseev wrote:
> nit: view ?

Done.

https://codereview.chromium.org/2700303002/diff/1/chrome/browser/ui/webui/chr...
chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h:470:
CoreOobeView* core_oobe_actor_ = nullptr;
On 2017/02/22 00:21:05, Alexander Alekseev wrote:
> nit: view ?

Done.

https://codereview.chromium.org/2700303002/diff/1/chrome/browser/ui/webui/chr...
File chrome/browser/ui/webui/chromeos/login/terms_of_service_screen_handler.cc
(right):

https://codereview.chromium.org/2700303002/diff/1/chrome/browser/ui/webui/chr...
chrome/browser/ui/webui/chromeos/login/terms_of_service_screen_handler.cc:40:
CoreOobeView* core_oobe_actor)
On 2017/02/22 00:21:05, Alexander Alekseev wrote:
> nit: view .

Done.

https://codereview.chromium.org/2700303002/diff/1/chrome/browser/ui/webui/chr...
File chrome/browser/ui/webui/chromeos/login/terms_of_service_screen_handler.h
(right):

https://codereview.chromium.org/2700303002/diff/1/chrome/browser/ui/webui/chr...
chrome/browser/ui/webui/chromeos/login/terms_of_service_screen_handler.h:24:
explicit TermsOfServiceScreenHandler(CoreOobeView* core_oobe_actor);
On 2017/02/22 00:21:05, Alexander Alekseev wrote:
> nit: view ?

Done.

https://codereview.chromium.org/2700303002/diff/1/chrome/browser/ui/webui/chr...
chrome/browser/ui/webui/chromeos/login/terms_of_service_screen_handler.h:73:
CoreOobeView* core_oobe_actor_ = nullptr;
On 2017/02/22 00:21:05, Alexander Alekseev wrote:
> nit: view_ ?

Done.

[commit-bot: I haz the power, 2017-02-22 01:05:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jdufault, 2017-02-22 01:07:38]

jdufault@chromium.org changed reviewers:
+ hidehiko@chromium.org

[jdufault, 2017-02-22 01:08:03]

hidehiko@ PTAL at chrome/browser/chromeos/arc

[commit-bot: I haz the power, 2017-02-22 03:08:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 03:08:45]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)

[hidehiko, 2017-02-23 05:34:08]

The change almost LG!
I walked through ARC related code, and just commented remaining "actor" in the
code and the comments.

https://codereview.chromium.org/2700303002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/arc/arc_session_manager_unittest.cc (right):

https://codereview.chromium.org/2700303002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/arc_session_manager_unittest.cc:730:
ArcTermsOfServiceOobeNegotiator::SetArcTermsOfServiceScreenActorForTesting(
s/Actor/View, too?

https://codereview.chromium.org/2700303002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/arc_session_manager_unittest.cc:754:
ArcTermsOfServiceOobeNegotiator::SetArcTermsOfServiceScreenActorForTesting(
ditto.

https://codereview.chromium.org/2700303002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/arc_session_manager_unittest.cc:773: void
ReportActorDestroyed() {
s/Actor/View/ here, too?

https://codereview.chromium.org/2700303002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/arc_session_manager_unittest.cc:844:
TEST_P(ArcSessionOobeOptInNegotiatorTest, OobeTermsActorDestroyed) {
s/Actor/View/ too_

https://codereview.chromium.org/2700303002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/arc/optin/arc_terms_of_service_oobe_negotiator.cc
(right):

https://codereview.chromium.org/2700303002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/optin/arc_terms_of_service_oobe_negotiator.cc:16:
chromeos::ArcTermsOfServiceScreenView* g_actor_for_testing = nullptr;
s/_actor_/_view_/ too?

https://codereview.chromium.org/2700303002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/arc/optin/arc_terms_of_service_oobe_negotiator.h
(right):

https://codereview.chromium.org/2700303002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/optin/arc_terms_of_service_oobe_negotiator.h:28:
static void SetArcTermsOfServiceScreenActorForTesting(
s/Actor/View/, too?

https://codereview.chromium.org/2700303002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/optin/arc_terms_of_service_oobe_negotiator.h:29:
chromeos::ArcTermsOfServiceScreenView* actor);
s/actor/view/ too?

https://codereview.chromium.org/2700303002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/optin/arc_terms_of_service_oobe_negotiator.h:33: //
chromeos::ArcTermsOfServiceScreenActorObserver. It removes observer from
s/Actor/View/, too?

https://codereview.chromium.org/2700303002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/optin/arc_terms_of_service_oobe_negotiator.h:34: //
|screen_actor_|, resets it, and then dispatches |accepted|. It is expected
s/actor_/view_/ too?

https://codereview.chromium.org/2700303002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/optin/arc_terms_of_service_oobe_negotiator.h:39: //
chromeos::ArcTermsOfServiceScreenActorObserver:
s/Actor/View/ too?

https://codereview.chromium.org/2700303002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/optin/arc_terms_of_service_oobe_negotiator.h:48: //
LoginDisplayHost is detached first then OnActorDestroyed is called.
s/Actor/View/g in the comment, too?

https://codereview.chromium.org/2700303002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/arc_kiosk_controller.h (right):

https://codereview.chromium.org/2700303002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/arc_kiosk_controller.h:61: //
ArcKioskSplashScreenActor::Delegate implementation:
s/Actor/View/ too?

https://codereview.chromium.org/2700303002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/arc_kiosk_controller.h:67:
ArcKioskSplashScreenView* const arc_kiosk_splash_screen_actor_;
s/_actor_/_view_/, too?

https://codereview.chromium.org/2700303002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/screens/arc_kiosk_splash_screen_view.h
(right):

https://codereview.chromium.org/2700303002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/screens/arc_kiosk_splash_screen_view.h:42: // Sets
screen this actor belongs to.
s/actor/view/

https://codereview.chromium.org/2700303002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/screens/arc_terms_of_service_screen.h
(right):

https://codereview.chromium.org/2700303002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/screens/arc_terms_of_service_screen.h:23:
ArcTermsOfServiceScreenView* actor);
s/actor/view/

https://codereview.chromium.org/2700303002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/screens/arc_terms_of_service_screen.h:30: //
ArcTermsOfServiceScreenActorObserver:
s/Actor/View/

https://codereview.chromium.org/2700303002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/screens/arc_terms_of_service_screen.h:33: void
OnViewDestroyed(ArcTermsOfServiceScreenView* actor) override;
s/actor/view/

https://codereview.chromium.org/2700303002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/screens/arc_terms_of_service_screen.h:36:
ArcTermsOfServiceScreenView* actor_;
s/actor_/view_/

https://codereview.chromium.org/2700303002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/screens/arc_terms_of_service_screen_view.h
(right):

https://codereview.chromium.org/2700303002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/screens/arc_terms_of_service_screen_view.h:22: //
Adds/Removes observer for actor.
s/actor/view/

https://codereview.chromium.org/2700303002/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/chromeos/login/arc_kiosk_splash_screen_handler.h
(right):

https://codereview.chromium.org/2700303002/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/chromeos/login/arc_kiosk_splash_screen_handler.h:36: //
ArcKioskSplashScreenActor implementation:
s/Actor/View/

https://codereview.chromium.org/2700303002/diff/40001/chrome/browser/ui/webui...
File
chrome/browser/ui/webui/chromeos/login/arc_terms_of_service_screen_handler.h
(right):

https://codereview.chromium.org/2700303002/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/chromeos/login/arc_terms_of_service_screen_handler.h:24:
// The sole implementation of the ArcTermsOfServiceScreenActor, using WebUI.
s/Actor/View/

https://codereview.chromium.org/2700303002/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/chromeos/login/arc_terms_of_service_screen_handler.h:41:
// ArcTermsOfServiceScreenActor:
s/Actor/View/

[jdufault, 2017-02-23 22:39:57]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 22:40:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 00:03:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 00:03:31]

Dry run: This issue passed the CQ dry run.

[jdufault, 2017-02-24 00:40:17]

https://codereview.chromium.org/2700303002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/arc/arc_session_manager_unittest.cc (right):

https://codereview.chromium.org/2700303002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/arc_session_manager_unittest.cc:730:
ArcTermsOfServiceOobeNegotiator::SetArcTermsOfServiceScreenActorForTesting(
On 2017/02/23 05:34:07, hidehiko wrote:
> s/Actor/View, too?

Done.

https://codereview.chromium.org/2700303002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/arc_session_manager_unittest.cc:754:
ArcTermsOfServiceOobeNegotiator::SetArcTermsOfServiceScreenActorForTesting(
On 2017/02/23 05:34:07, hidehiko wrote:
> ditto.

Done.

https://codereview.chromium.org/2700303002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/arc_session_manager_unittest.cc:773: void
ReportActorDestroyed() {
On 2017/02/23 05:34:07, hidehiko wrote:
> s/Actor/View/ here, too?

Done.

https://codereview.chromium.org/2700303002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/arc_session_manager_unittest.cc:844:
TEST_P(ArcSessionOobeOptInNegotiatorTest, OobeTermsActorDestroyed) {
On 2017/02/23 05:34:07, hidehiko wrote:
> s/Actor/View/ too_

Done.

https://codereview.chromium.org/2700303002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/arc/optin/arc_terms_of_service_oobe_negotiator.cc
(right):

https://codereview.chromium.org/2700303002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/optin/arc_terms_of_service_oobe_negotiator.cc:16:
chromeos::ArcTermsOfServiceScreenView* g_actor_for_testing = nullptr;
On 2017/02/23 05:34:07, hidehiko wrote:
> s/_actor_/_view_/ too?

Done.

https://codereview.chromium.org/2700303002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/arc/optin/arc_terms_of_service_oobe_negotiator.h
(right):

https://codereview.chromium.org/2700303002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/optin/arc_terms_of_service_oobe_negotiator.h:28:
static void SetArcTermsOfServiceScreenActorForTesting(
On 2017/02/23 05:34:08, hidehiko wrote:
> s/Actor/View/, too?

Done.

https://codereview.chromium.org/2700303002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/optin/arc_terms_of_service_oobe_negotiator.h:29:
chromeos::ArcTermsOfServiceScreenView* actor);
On 2017/02/23 05:34:07, hidehiko wrote:
> s/actor/view/ too?

Done.

https://codereview.chromium.org/2700303002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/optin/arc_terms_of_service_oobe_negotiator.h:33: //
chromeos::ArcTermsOfServiceScreenActorObserver. It removes observer from
On 2017/02/23 05:34:07, hidehiko wrote:
> s/Actor/View/, too?

Done.

https://codereview.chromium.org/2700303002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/optin/arc_terms_of_service_oobe_negotiator.h:34: //
|screen_actor_|, resets it, and then dispatches |accepted|. It is expected
On 2017/02/23 05:34:08, hidehiko wrote:
> s/actor_/view_/ too?

Done.

https://codereview.chromium.org/2700303002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/optin/arc_terms_of_service_oobe_negotiator.h:39: //
chromeos::ArcTermsOfServiceScreenActorObserver:
On 2017/02/23 05:34:08, hidehiko wrote:
> s/Actor/View/ too?

Done.

https://codereview.chromium.org/2700303002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/optin/arc_terms_of_service_oobe_negotiator.h:48: //
LoginDisplayHost is detached first then OnActorDestroyed is called.
On 2017/02/23 05:34:07, hidehiko wrote:
> s/Actor/View/g in the comment, too?

Done.

https://codereview.chromium.org/2700303002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/arc_kiosk_controller.h (right):

https://codereview.chromium.org/2700303002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/arc_kiosk_controller.h:61: //
ArcKioskSplashScreenActor::Delegate implementation:
On 2017/02/23 05:34:08, hidehiko wrote:
> s/Actor/View/ too?

Done.

https://codereview.chromium.org/2700303002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/arc_kiosk_controller.h:67:
ArcKioskSplashScreenView* const arc_kiosk_splash_screen_actor_;
On 2017/02/23 05:34:08, hidehiko wrote:
> s/_actor_/_view_/, too?

Done.

https://codereview.chromium.org/2700303002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/screens/arc_kiosk_splash_screen_view.h
(right):

https://codereview.chromium.org/2700303002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/screens/arc_kiosk_splash_screen_view.h:42: // Sets
screen this actor belongs to.
On 2017/02/23 05:34:08, hidehiko wrote:
> s/actor/view/

Done.

https://codereview.chromium.org/2700303002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/screens/arc_terms_of_service_screen.h
(right):

https://codereview.chromium.org/2700303002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/screens/arc_terms_of_service_screen.h:23:
ArcTermsOfServiceScreenView* actor);
On 2017/02/23 05:34:08, hidehiko wrote:
> s/actor/view/

Done.

https://codereview.chromium.org/2700303002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/screens/arc_terms_of_service_screen.h:30: //
ArcTermsOfServiceScreenActorObserver:
On 2017/02/23 05:34:08, hidehiko wrote:
> s/Actor/View/

Done.

https://codereview.chromium.org/2700303002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/screens/arc_terms_of_service_screen.h:33: void
OnViewDestroyed(ArcTermsOfServiceScreenView* actor) override;
On 2017/02/23 05:34:08, hidehiko wrote:
> s/actor/view/

Done.

https://codereview.chromium.org/2700303002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/screens/arc_terms_of_service_screen.h:36:
ArcTermsOfServiceScreenView* actor_;
On 2017/02/23 05:34:08, hidehiko wrote:
> s/actor_/view_/

Done.

https://codereview.chromium.org/2700303002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/screens/arc_terms_of_service_screen_view.h
(right):

https://codereview.chromium.org/2700303002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/screens/arc_terms_of_service_screen_view.h:22: //
Adds/Removes observer for actor.
On 2017/02/23 05:34:08, hidehiko wrote:
> s/actor/view/

Done.

https://codereview.chromium.org/2700303002/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/chromeos/login/arc_kiosk_splash_screen_handler.h
(right):

https://codereview.chromium.org/2700303002/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/chromeos/login/arc_kiosk_splash_screen_handler.h:36: //
ArcKioskSplashScreenActor implementation:
On 2017/02/23 05:34:08, hidehiko wrote:
> s/Actor/View/

Done.

https://codereview.chromium.org/2700303002/diff/40001/chrome/browser/ui/webui...
File
chrome/browser/ui/webui/chromeos/login/arc_terms_of_service_screen_handler.h
(right):

https://codereview.chromium.org/2700303002/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/chromeos/login/arc_terms_of_service_screen_handler.h:24:
// The sole implementation of the ArcTermsOfServiceScreenActor, using WebUI.
On 2017/02/23 05:34:08, hidehiko wrote:
> s/Actor/View/

Done.

https://codereview.chromium.org/2700303002/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/chromeos/login/arc_terms_of_service_screen_handler.h:41:
// ArcTermsOfServiceScreenActor:
On 2017/02/23 05:34:08, hidehiko wrote:
> s/Actor/View/

Done.

[hidehiko, 2017-02-24 05:27:32]

c/b/c/arc LGTM. Thank you!

[jdufault, 2017-02-24 17:51:08]

The CQ bit was checked by jdufault@chromium.org

[jdufault, 2017-02-24 17:51:09]

The patchset sent to the CQ was uploaded after l-g-t-m from alemate@chromium.org
Link to the patchset: https://codereview.chromium.org/2700303002/#ps60001
(title: "More renames")

[commit-bot: I haz the power, 2017-02-24 17:51:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 18:04:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 18:04:44]

Failed to apply patch for
chrome/browser/chromeos/arc/arc_session_manager_unittest.cc:
While running git apply --index -p1;
  error: patch failed:
chrome/browser/chromeos/arc/arc_session_manager_unittest.cc:22
  error: chrome/browser/chromeos/arc/arc_session_manager_unittest.cc: patch does
not apply

Patch:       chrome/browser/chromeos/arc/arc_session_manager_unittest.cc
Index: chrome/browser/chromeos/arc/arc_session_manager_unittest.cc
diff --git a/chrome/browser/chromeos/arc/arc_session_manager_unittest.cc
b/chrome/browser/chromeos/arc/arc_session_manager_unittest.cc
index
98d8e1479b2739542722559283209265f5671b64..89dadf30d036a49809d37e23ecf6627dde646d95
100644
--- a/chrome/browser/chromeos/arc/arc_session_manager_unittest.cc
+++ b/chrome/browser/chromeos/arc/arc_session_manager_unittest.cc
@@ -22,8 +22,8 @@
 #include "chrome/browser/chromeos/arc/arc_session_manager.h"
 #include
"chrome/browser/chromeos/arc/optin/arc_terms_of_service_oobe_negotiator.h"
 #include "chrome/browser/chromeos/arc/test/arc_data_removed_waiter.h"
-#include
"chrome/browser/chromeos/login/screens/arc_terms_of_service_screen_actor.h"
-#include
"chrome/browser/chromeos/login/screens/arc_terms_of_service_screen_actor_observer.h"
+#include
"chrome/browser/chromeos/login/screens/arc_terms_of_service_screen_view.h"
+#include
"chrome/browser/chromeos/login/screens/arc_terms_of_service_screen_view_observer.h"
 #include "chrome/browser/chromeos/login/ui/login_display_host.h"
 #include "chrome/browser/chromeos/login/users/fake_chrome_user_manager.h"
 #include "chrome/browser/chromeos/login/users/scoped_user_manager_enabler.h"
@@ -717,7 +717,7 @@ TEST_F(ArcSessionOobeOptInTest, OobeOptInActive) {
 
 class ArcSessionOobeOptInNegotiatorTest
     : public ArcSessionOobeOptInTest,
-      public chromeos::ArcTermsOfServiceScreenActor,
+      public chromeos::ArcTermsOfServiceScreenView,
       public testing::WithParamInterface<bool> {
  public:
   ArcSessionOobeOptInNegotiatorTest() = default;
@@ -727,7 +727,7 @@ class ArcSessionOobeOptInNegotiatorTest
 
     AppendEnableArcOOBEOptInSwitch();
 
-    ArcTermsOfServiceOobeNegotiator::SetArcTermsOfServiceScreenActorForTesting(
+    ArcTermsOfServiceOobeNegotiator::SetArcTermsOfServiceScreenViewForTesting(
         this);
 
     GetFakeUserManager()->set_current_user_new(true);
@@ -751,7 +751,7 @@ class ArcSessionOobeOptInNegotiatorTest
     // Correctly stop service.
     arc_session_manager()->Shutdown();
 
-    ArcTermsOfServiceOobeNegotiator::SetArcTermsOfServiceScreenActorForTesting(
+    ArcTermsOfServiceOobeNegotiator::SetArcTermsOfServiceScreenViewForTesting(
         nullptr);
 
     ArcSessionOobeOptInTest::TearDown();
@@ -770,9 +770,9 @@ class ArcSessionOobeOptInNegotiatorTest
     base::RunLoop().RunUntilIdle();
   }
 
-  void ReportActorDestroyed() {
+  void ReportViewDestroyed() {
     for (auto& observer : observer_list_)
-      observer.OnActorDestroyed(this);
+      observer.OnViewDestroyed(this);
     base::RunLoop().RunUntilIdle();
   }
 
@@ -788,17 +788,17 @@ class ArcSessionOobeOptInNegotiatorTest
     ArcDataRemovedWaiter().Wait();
   }
 
-  chromeos::ArcTermsOfServiceScreenActor* actor() { return this; }
+  chromeos::ArcTermsOfServiceScreenView* view() { return this; }
 
  private:
-  // ArcTermsOfServiceScreenActor:
+  // ArcTermsOfServiceScreenView:
   void AddObserver(
-      chromeos::ArcTermsOfServiceScreenActorObserver* observer) override {
+      chromeos::ArcTermsOfServiceScreenViewObserver* observer) override {
     observer_list_.AddObserver(observer);
   }
 
   void RemoveObserver(
-      chromeos::ArcTermsOfServiceScreenActorObserver* observer) override {
+      chromeos::ArcTermsOfServiceScreenViewObserver* observer) override {
     observer_list_.RemoveObserver(observer);
   }
 
@@ -810,7 +810,7 @@ class ArcSessionOobeOptInNegotiatorTest
 
   void Hide() override {}
 
-  base::ObserverList<chromeos::ArcTermsOfServiceScreenActorObserver>
+  base::ObserverList<chromeos::ArcTermsOfServiceScreenViewObserver>
       observer_list_;
 
   DISALLOW_COPY_AND_ASSIGN(ArcSessionOobeOptInNegotiatorTest);
@@ -821,7 +821,7 @@
INSTANTIATE_TEST_CASE_P(ArcSessionOobeOptInNegotiatorTestImpl,
                         ::testing::Values(true, false));
 
 TEST_P(ArcSessionOobeOptInNegotiatorTest, OobeTermsAccepted) {
-  actor()->Show();
+  view()->Show();
   MaybeWaitForDataRemoved();
   EXPECT_EQ(ArcSessionManager::State::SHOWING_TERMS_OF_SERVICE,
             arc_session_manager()->state());
@@ -831,7 +831,7 @@ TEST_P(ArcSessionOobeOptInNegotiatorTest, OobeTermsAccepted)
{
 }
 
 TEST_P(ArcSessionOobeOptInNegotiatorTest, OobeTermsRejected) {
-  actor()->Show();
+  view()->Show();
   MaybeWaitForDataRemoved();
   EXPECT_EQ(ArcSessionManager::State::SHOWING_TERMS_OF_SERVICE,
             arc_session_manager()->state());
@@ -841,13 +841,13 @@ TEST_P(ArcSessionOobeOptInNegotiatorTest,
OobeTermsRejected) {
                arc_session_manager()->IsArcPlayStoreEnabled());
 }
 
-TEST_P(ArcSessionOobeOptInNegotiatorTest, OobeTermsActorDestroyed) {
-  actor()->Show();
+TEST_P(ArcSessionOobeOptInNegotiatorTest, OobeTermsViewDestroyed) {
+  view()->Show();
   MaybeWaitForDataRemoved();
   EXPECT_EQ(ArcSessionManager::State::SHOWING_TERMS_OF_SERVICE,
             arc_session_manager()->state());
   CloseLoginDisplayHost();
-  ReportActorDestroyed();
+  ReportViewDestroyed();
   EXPECT_EQ(ArcSessionManager::State::STOPPED, arc_session_manager()->state());
   EXPECT_FALSE(!IsManagedUser() &&
                arc_session_manager()->IsArcPlayStoreEnabled());

[jdufault, 2017-02-24 18:34:55]

The CQ bit was checked by jdufault@chromium.org

[jdufault, 2017-02-24 18:34:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
hidehiko@chromium.org, alemate@chromium.org
Link to the patchset: https://codereview.chromium.org/2700303002/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2017-02-24 18:35:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 19:49:18]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1487961295774320,
"parent_rev": "5113973bc4260b94300d81502935d5ebab57a1d0", "commit_rev":
"eda3863d1963478c04b05d846f3ce34cac5283ee"}

[commit-bot: I haz the power, 2017-02-24 19:50:02]

Description was changed from

==========
cros: Unify oobe View/Actor naming to just View.

BUG=672142
==========

to

==========
cros: Unify oobe View/Actor naming to just View.

BUG=672142

Review-Url: https://codereview.chromium.org/2700303002
Cr-Commit-Position: refs/heads/master@{#452906}
Committed:
https://chromium.googlesource.com/chromium/src/+/eda3863d1963478c04b05d846f3c...
==========

[commit-bot: I haz the power, 2017-02-24 19:50:04]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/eda3863d1963478c04b05d846f3c...