chrome/browser/chromeos/login/enrollment/enrollment_screen_browsertest.cc - Issue 2700303002: cros: Unify oobe View/Actor naming to just View.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/enrollment/enrollment_screen_browsertest.cc

Issue 2700303002: cros: Unify oobe View/Actor naming to just View. (Closed)

Patch Set: Rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/enrollment/enrollment_screen_actor.h ('k') | chrome/browser/chromeos/login/enrollment/enrollment_screen_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/enrollment/enrollment_screen_browsertest.cc

diff --git a/chrome/browser/chromeos/login/enrollment/enrollment_screen_browsertest.cc b/chrome/browser/chromeos/login/enrollment/enrollment_screen_browsertest.cc

index a79d8dc25a56c88f1c2847e5aeb46517c36948d7..3e210ce8c8b555b8a369de1fde82d0ea41260c78 100644

--- a/chrome/browser/chromeos/login/enrollment/enrollment_screen_browsertest.cc

+++ b/chrome/browser/chromeos/login/enrollment/enrollment_screen_browsertest.cc

@@ -136,25 +136,25 @@ IN_PROC_BROWSER_TEST_F(EnrollmentScreenTest, EnrollmentSpinner) {

EnrollmentScreen* enrollment_screen = EnrollmentScreen::Get(wcontroller);

ASSERT_TRUE(enrollment_screen);

- EnrollmentScreenActor* actor = enrollment_screen->GetActor();

- ASSERT_TRUE(actor);

+ EnrollmentScreenView* view = enrollment_screen->GetView();

+ ASSERT_TRUE(view);

test::JSChecker checker(

LoginDisplayHost::default_host()->GetWebUILoginView()->GetWebContents());

// Run through the flow

- actor->Show();

+ view->Show();

OobeScreenWaiter(OobeScreen::SCREEN_OOBE_ENROLLMENT).Wait();

checker.ExpectTrue(

"window.getComputedStyle(document.getElementById('oauth-enroll-step-"

"signin')).display !== 'none'");

- actor->ShowEnrollmentSpinnerScreen();

+ view->ShowEnrollmentSpinnerScreen();

checker.ExpectTrue(

"window.getComputedStyle(document.getElementById('oauth-enroll-step-"

"working')).display !== 'none'");

- actor->ShowAttestationBasedEnrollmentSuccessScreen("fake domain");

+ view->ShowAttestationBasedEnrollmentSuccessScreen("fake domain");

checker.ExpectTrue(

"window.getComputedStyle(document.getElementById('oauth-enroll-step-abe-"

"success')).display !== 'none'");