Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(980)

Issue 2700283002: rebaseline-cl: Only support local branches, drop Rietveld support. (Closed)

Created:
3 years, 10 months ago by qyearsley
Modified:
3 years, 10 months ago
Reviewers:
wkorman
CC:
blink-reviews, cbentzel+watch_chromium.org, chromium-reviews, drott, jeffcarp, net-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

rebaseline-cl: Only support local branches, drop Rietveld support. This continues on from http://crrev.com/2692423005, and also changes rebaseline-cl so that: - Git.changed_files is used instead of Rietveld.changed_files - The --issue flag is removed BUG=671684 Review-Url: https://codereview.chromium.org/2700283002 Cr-Commit-Position: refs/heads/master@{#452142} Committed: https://chromium.googlesource.com/chromium/src/+/2f99ba4adc9c23b0e611985304dd3a9c52235ed9

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -76 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/git.py View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/git_mock.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py View 1 7 chunks +8 lines, -27 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py View 1 13 chunks +28 lines, -46 lines 0 comments Download

Messages

Total messages: 23 (17 generated)
qyearsley
Hi Walter, could you review this? The purpose of this CL is to drop support ...
3 years, 10 months ago (2017-02-21 16:28:58 UTC) #12
wkorman
lgtm
3 years, 10 months ago (2017-02-21 23:01:08 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2700283002/20001
3 years, 10 months ago (2017-02-21 23:31:04 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on ...
3 years, 10 months ago (2017-02-22 01:38:08 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2700283002/40001
3 years, 10 months ago (2017-02-22 17:18:59 UTC) #20
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 18:32:16 UTC) #23
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/2f99ba4adc9c23b0e611985304dd...

Powered by Google App Engine
This is Rietveld 408576698