Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/git.py

Issue 2700283002: rebaseline-cl: Only support local branches, drop Rietveld support. (Closed)
Patch Set: Rebased Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/git_mock.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/git.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/git.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/git.py
index f91fc421da603cffc4dbacb1dd4dbe9c2738558f..f50d7d8edd29555538d6adac839f9aaa6fd13d1c 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/git.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/git.py
@@ -237,13 +237,13 @@ class Git(object):
return self._remote_merge_base()
- def changed_files(self, git_commit=None):
+ def changed_files(self, git_commit=None, diff_filter='ADM'):
# FIXME: --diff-filter could be used to avoid the "extract_filenames" step.
status_command = ['diff', '-r', '--name-status',
"--no-renames", "--no-ext-diff", "--full-index", self._merge_base(git_commit)]
# FIXME: I'm not sure we're returning the same set of files that SVN.changed_files is.
# Added (A), Copied (C), Deleted (D), Modified (M), Renamed (R)
- return self._run_status_and_extract_filenames(status_command, self._status_regexp("ADM"))
+ return self._run_status_and_extract_filenames(status_command, self._status_regexp(diff_filter))
def added_files(self):
return self._run_status_and_extract_filenames(self.status_command(), self._status_regexp("A"))
« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/git_mock.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698