vpython: Add wheel parsing/management package.

vpython: Add wheel parsing/management package.

Add the "wheel" package to "vpython". This package allows "vpython" to
examine and understand the Python wheel file naming conventions, and
manipulate them on the filesystem.

BUG=chromium:691818
TEST=unit

Review-Url: https://codereview.chromium.org/2700273002
Committed: https://github.com/luci/luci-go/commit/d225f829fb168a0fe57b96206a6210b4f728c9e9

[dnj, 2017-02-17 23:13:42]

Description was changed from

==========
Updated patchset dependency

vpython: Add wheel parsing/management package.

Add the "wheel" package to "vpython". This package allows "vpython" to
examine and understand the Python wheel file naming conventions, and
manipulate them on the filesystem.

BUG=chromium:691818
TEST=unit
==========

to

==========
vpython: Add wheel parsing/management package.

Add the "wheel" package to "vpython". This package allows "vpython" to
examine and understand the Python wheel file naming conventions, and
manipulate them on the filesystem.

BUG=chromium:691818
TEST=unit
==========

[dnj, 2017-02-17 23:17:22]

dnj@chromium.org changed reviewers:
+ iannucci@chromium.org

[dnj, 2017-02-17 23:17:22]

PTAL! This is part of a larger "vpython" CL set for the tool. More information
can be found in the bug, or in the linked design doc:
https://docs.google.com/document/d/1GKN7rtW6-006RbG_Ryh6vr4TpUxSxJlPSCKFLq2nO...

Total CL set is:
https://codereview.chromium.org/2703463006/ (README, protobufs)
https://codereview.chromium.org/2703793003/ (filesystem)
https://codereview.chromium.org/2700273002/ (wheel)
https://codereview.chromium.org/2705623003/ (environment spec)
https://codereview.chromium.org/2701073002/ (Python interpreter management)
https://codereview.chromium.org/2699063004/ (main VirtualEnv package)
https://codereview.chromium.org/2699223002/ (CIPD support)
https://codereview.chromium.org/2702873002/ (package entry point)
https://codereview.chromium.org/2705593003/ (main application)
https://chromium-review.googlesource.com/c/444040/ (Infra entry point)

[iannucci, 2017-02-21 08:34:02]

lgtm

https://codereview.chromium.org/2700273002/diff/1/vpython/wheel/wheel.go
File vpython/wheel/wheel.go (right):

https://codereview.chromium.org/2700273002/diff/1/vpython/wheel/wheel.go#newc...
vpython/wheel/wheel.go:34: wn.BuildTag,
if BuildTag is empty, does this render correctly, or does it get an extra '-'?

https://codereview.chromium.org/2700273002/diff/1/vpython/wheel/wheel.go#newc...
vpython/wheel/wheel.go:74: // parsed wheel names.
note: non-recursively.

Is this really glob-related (other than the implementation)? Maybe it should be
`wheel.AllInDir(dir string)` ?

https://codereview.chromium.org/2700273002/diff/1/vpython/wheel/wheel.go#newc...
vpython/wheel/wheel.go:81: D("pattern", globPattern).
not in reason?

https://codereview.chromium.org/2700273002/diff/1/vpython/wheel/wheel.go#newc...
vpython/wheel/wheel.go:104: D("dir", dir).
in reason?

https://codereview.chromium.org/2700273002/diff/1/vpython/wheel/wheel.go#newc...
vpython/wheel/wheel.go:113: // WriteRequirementsFile writes a valid
"requirements.txt"-style pip reuirements
requirements

https://codereview.chromium.org/2700273002/diff/1/vpython/wheel/wheel.go#newc...
vpython/wheel/wheel.go:116: // The generated requirements will request the exact
wheel version.
"exact wheel version" meaning a hash? Or the approximate semver version?

https://codereview.chromium.org/2700273002/diff/1/vpython/wheel/wheel.go#newc...
vpython/wheel/wheel.go:121: }
why not defer close?

https://codereview.chromium.org/2700273002/diff/1/vpython/wheel/wheel_test.go
File vpython/wheel/wheel_test.go (right):

https://codereview.chromium.org/2700273002/diff/1/vpython/wheel/wheel_test.go...
vpython/wheel/wheel_test.go:23: BuildTag:     "0",
try one with empty BuildTag

https://codereview.chromium.org/2700273002/diff/1/vpython/wheel/wheel_test.go...
vpython/wheel/wheel_test.go:102: So(wn, ShouldResemble, tc.exp)
do a round-trip here

[dnj, 2017-02-21 18:19:08]

https://codereview.chromium.org/2700273002/diff/1/vpython/wheel/wheel.go
File vpython/wheel/wheel.go (right):

https://codereview.chromium.org/2700273002/diff/1/vpython/wheel/wheel.go#newc...
vpython/wheel/wheel.go:34: wn.BuildTag,
On 2017/02/21 08:34:01, iannucci wrote:
> if BuildTag is empty, does this render correctly, or does it get an extra '-'?

It does not. Fixed.

https://codereview.chromium.org/2700273002/diff/1/vpython/wheel/wheel.go#newc...
vpython/wheel/wheel.go:74: // parsed wheel names.
On 2017/02/21 08:34:02, iannucci wrote:
> note: non-recursively.
> 
> Is this really glob-related (other than the implementation)? Maybe it should
be
> `wheel.AllInDir(dir string)` ?

Done. Changed to "ScanDir".

https://codereview.chromium.org/2700273002/diff/1/vpython/wheel/wheel.go#newc...
vpython/wheel/wheel.go:81: D("pattern", globPattern).
On 2017/02/21 08:34:01, iannucci wrote:
> not in reason?

Acknowledged.

https://codereview.chromium.org/2700273002/diff/1/vpython/wheel/wheel.go#newc...
vpython/wheel/wheel.go:104: D("dir", dir).
On 2017/02/21 08:34:01, iannucci wrote:
> in reason?

Acknowledged.

https://codereview.chromium.org/2700273002/diff/1/vpython/wheel/wheel.go#newc...
vpython/wheel/wheel.go:113: // WriteRequirementsFile writes a valid
"requirements.txt"-style pip reuirements
On 2017/02/21 08:34:01, iannucci wrote:
> requirements

Done.

https://codereview.chromium.org/2700273002/diff/1/vpython/wheel/wheel.go#newc...
vpython/wheel/wheel.go:116: // The generated requirements will request the exact
wheel version.
On 2017/02/21 08:34:02, iannucci wrote:
> "exact wheel version" meaning a hash? Or the approximate semver version?

semver "==", clarified.

https://codereview.chromium.org/2700273002/diff/1/vpython/wheel/wheel.go#newc...
vpython/wheel/wheel.go:121: }
On 2017/02/21 08:34:01, iannucci wrote:
> why not defer close?

meh didn't want to use awkward defer error assignment, but OK

https://codereview.chromium.org/2700273002/diff/1/vpython/wheel/wheel_test.go
File vpython/wheel/wheel_test.go (right):

https://codereview.chromium.org/2700273002/diff/1/vpython/wheel/wheel_test.go...
vpython/wheel/wheel_test.go:23: BuildTag:     "0",
On 2017/02/21 08:34:02, iannucci wrote:
> try one with empty BuildTag

Done.

https://codereview.chromium.org/2700273002/diff/1/vpython/wheel/wheel_test.go...
vpython/wheel/wheel_test.go:102: So(wn, ShouldResemble, tc.exp)
On 2017/02/21 08:34:02, iannucci wrote:
> do a round-trip here

Done.

[dnj, 2017-02-22 07:22:36]

The CQ bit was checked by dnj@chromium.org

[dnj, 2017-02-22 07:22:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
iannucci@chromium.org
Link to the patchset: https://codereview.chromium.org/2700273002/#ps20001
(title: "rebase, comments")

[commit-bot: I haz the power, 2017-02-22 07:22:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 07:28:12]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487748156123880,
"parent_rev": "091cb1591f7a0516f730228126c04e5574dc7db0", "commit_rev":
"d225f829fb168a0fe57b96206a6210b4f728c9e9"}

[commit-bot: I haz the power, 2017-02-22 07:28:16]

Description was changed from

==========
vpython: Add wheel parsing/management package.

Add the "wheel" package to "vpython". This package allows "vpython" to
examine and understand the Python wheel file naming conventions, and
manipulate them on the filesystem.

BUG=chromium:691818
TEST=unit
==========

to

==========
vpython: Add wheel parsing/management package.

Add the "wheel" package to "vpython". This package allows "vpython" to
examine and understand the Python wheel file naming conventions, and
manipulate them on the filesystem.

BUG=chromium:691818
TEST=unit

Review-Url: https://codereview.chromium.org/2700273002
Committed:
https://github.com/luci/luci-go/commit/d225f829fb168a0fe57b96206a6210b4f728c9e9
==========

[commit-bot: I haz the power, 2017-02-22 07:28:16]

Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/d225f829fb168a0fe57b96206a6210b4f728c9e9