Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 2700273002: vpython: Add wheel parsing/management package. (Closed)

Created:
3 years, 10 months ago by dnj
Modified:
3 years, 10 months ago
Reviewers:
iannucci
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

vpython: Add wheel parsing/management package. Add the "wheel" package to "vpython". This package allows "vpython" to examine and understand the Python wheel file naming conventions, and manipulate them on the filesystem. BUG=chromium:691818 TEST=unit Review-Url: https://codereview.chromium.org/2700273002 Committed: https://github.com/luci/luci-go/commit/d225f829fb168a0fe57b96206a6210b4f728c9e9

Patch Set 1 #

Total comments: 18

Patch Set 2 : rebase, comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+338 lines, -0 lines) Patch
A vpython/wheel/wheel.go View 1 1 chunk +156 lines, -0 lines 0 comments Download
A vpython/wheel/wheel_test.go View 1 1 chunk +182 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 11 (6 generated)
dnj
PTAL! This is part of a larger "vpython" CL set for the tool. More information ...
3 years, 10 months ago (2017-02-17 23:17:22 UTC) #3
iannucci
lgtm https://codereview.chromium.org/2700273002/diff/1/vpython/wheel/wheel.go File vpython/wheel/wheel.go (right): https://codereview.chromium.org/2700273002/diff/1/vpython/wheel/wheel.go#newcode34 vpython/wheel/wheel.go:34: wn.BuildTag, if BuildTag is empty, does this render ...
3 years, 10 months ago (2017-02-21 08:34:02 UTC) #4
dnj
https://codereview.chromium.org/2700273002/diff/1/vpython/wheel/wheel.go File vpython/wheel/wheel.go (right): https://codereview.chromium.org/2700273002/diff/1/vpython/wheel/wheel.go#newcode34 vpython/wheel/wheel.go:34: wn.BuildTag, On 2017/02/21 08:34:01, iannucci wrote: > if BuildTag ...
3 years, 10 months ago (2017-02-21 18:19:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2700273002/20001
3 years, 10 months ago (2017-02-22 07:22:39 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 07:28:16 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/d225f829fb168a0fe57b96206a6210b4f728c9e9

Powered by Google App Engine
This is Rietveld 408576698