Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 2700253002: Redirect SingleThreadTaskRunner creation to the SchedulerSingleThreadTaskRunnerManager (Closed)

Created:
3 years, 10 months ago by robliao
Modified:
3 years, 9 months ago
Reviewers:
gab, fdoray
CC:
chromium-reviews, gab+watch_chromium.org, robliao+watch_chromium.org, fdoray+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Redirect SingleThreadTaskRunner creation to the SchedulerSingleThreadTaskRunnerManager Reference Change: https://codereview.chromium.org/2686593003/ BUG=684080 Review-Url: https://codereview.chromium.org/2700253002 Cr-Commit-Position: refs/heads/master@{#456438} Committed: https://chromium.googlesource.com/chromium/src/+/29611dbb462c16291460e4c14f8de7a5026c6cee

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M base/task_scheduler/task_scheduler_impl.h View 2 chunks +3 lines, -0 lines 0 comments Download
M base/task_scheduler/task_scheduler_impl.cc View 4 chunks +9 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 19 (13 generated)
robliao
And this should complete the sequence!
3 years, 10 months ago (2017-02-17 22:48:30 UTC) #2
fdoray
lgtm
3 years, 10 months ago (2017-02-22 18:27:33 UTC) #4
gab
Can we have cleanup of old code as part of this CL (it's always easier ...
3 years, 10 months ago (2017-02-22 18:47:31 UTC) #5
robliao
On 2017/02/22 18:47:31, gab wrote: > Can we have cleanup of old code as part ...
3 years, 10 months ago (2017-02-22 19:17:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2700253002/1
3 years, 9 months ago (2017-03-13 18:17:01 UTC) #16
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 18:31:26 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/29611dbb462c16291460e4c14f8d...

Powered by Google App Engine
This is Rietveld 408576698