Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Side by Side Diff: base/task_scheduler/task_scheduler_impl.cc

Issue 2700253002: Redirect SingleThreadTaskRunner creation to the SchedulerSingleThreadTaskRunnerManager (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/task_scheduler/task_scheduler_impl.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/task_scheduler/task_scheduler_impl.h" 5 #include "base/task_scheduler/task_scheduler_impl.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/bind_helpers.h" 10 #include "base/bind_helpers.h"
11 #include "base/memory/ptr_util.h" 11 #include "base/memory/ptr_util.h"
12 #include "base/task_scheduler/delayed_task_manager.h" 12 #include "base/task_scheduler/delayed_task_manager.h"
13 #include "base/task_scheduler/scheduler_single_thread_task_runner_manager.h"
13 #include "base/task_scheduler/scheduler_worker_pool_params.h" 14 #include "base/task_scheduler/scheduler_worker_pool_params.h"
14 #include "base/task_scheduler/sequence_sort_key.h" 15 #include "base/task_scheduler/sequence_sort_key.h"
15 #include "base/task_scheduler/task.h" 16 #include "base/task_scheduler/task.h"
16 #include "base/task_scheduler/task_tracker.h" 17 #include "base/task_scheduler/task_tracker.h"
17 #include "build/build_config.h" 18 #include "build/build_config.h"
18 19
19 #if defined(OS_POSIX) && !defined(OS_NACL_SFI) 20 #if defined(OS_POSIX) && !defined(OS_NACL_SFI)
20 #include "base/task_scheduler/task_tracker_posix.h" 21 #include "base/task_scheduler/task_tracker_posix.h"
21 #endif 22 #endif
22 23
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
59 scoped_refptr<SequencedTaskRunner> 60 scoped_refptr<SequencedTaskRunner>
60 TaskSchedulerImpl::CreateSequencedTaskRunnerWithTraits( 61 TaskSchedulerImpl::CreateSequencedTaskRunnerWithTraits(
61 const TaskTraits& traits) { 62 const TaskTraits& traits) {
62 return GetWorkerPoolForTraits(traits)->CreateSequencedTaskRunnerWithTraits( 63 return GetWorkerPoolForTraits(traits)->CreateSequencedTaskRunnerWithTraits(
63 traits); 64 traits);
64 } 65 }
65 66
66 scoped_refptr<SingleThreadTaskRunner> 67 scoped_refptr<SingleThreadTaskRunner>
67 TaskSchedulerImpl::CreateSingleThreadTaskRunnerWithTraits( 68 TaskSchedulerImpl::CreateSingleThreadTaskRunnerWithTraits(
68 const TaskTraits& traits) { 69 const TaskTraits& traits) {
69 return GetWorkerPoolForTraits(traits)->CreateSingleThreadTaskRunnerWithTraits( 70 return single_thread_task_runner_manager_
70 traits); 71 ->CreateSingleThreadTaskRunnerWithTraits(traits);
71 } 72 }
72 73
73 std::vector<const HistogramBase*> TaskSchedulerImpl::GetHistograms() const { 74 std::vector<const HistogramBase*> TaskSchedulerImpl::GetHistograms() const {
74 std::vector<const HistogramBase*> histograms; 75 std::vector<const HistogramBase*> histograms;
75 for (const auto& worker_pool : worker_pools_) 76 for (const auto& worker_pool : worker_pools_)
76 worker_pool->GetHistograms(&histograms); 77 worker_pool->GetHistograms(&histograms);
77 78
78 return histograms; 79 return histograms;
79 } 80 }
80 81
(...skipping 10 matching lines...) Expand all
91 92
92 void TaskSchedulerImpl::FlushForTesting() { 93 void TaskSchedulerImpl::FlushForTesting() {
93 DCHECK(task_tracker_); 94 DCHECK(task_tracker_);
94 task_tracker_->Flush(); 95 task_tracker_->Flush();
95 } 96 }
96 97
97 void TaskSchedulerImpl::JoinForTesting() { 98 void TaskSchedulerImpl::JoinForTesting() {
98 #if DCHECK_IS_ON() 99 #if DCHECK_IS_ON()
99 DCHECK(!join_for_testing_returned_.IsSet()); 100 DCHECK(!join_for_testing_returned_.IsSet());
100 #endif 101 #endif
102 single_thread_task_runner_manager_->JoinForTesting();
101 for (const auto& worker_pool : worker_pools_) 103 for (const auto& worker_pool : worker_pools_)
102 worker_pool->DisallowWorkerDetachmentForTesting(); 104 worker_pool->DisallowWorkerDetachmentForTesting();
103 for (const auto& worker_pool : worker_pools_) 105 for (const auto& worker_pool : worker_pools_)
104 worker_pool->JoinForTesting(); 106 worker_pool->JoinForTesting();
105 service_thread_.Stop(); 107 service_thread_.Stop();
106 #if DCHECK_IS_ON() 108 #if DCHECK_IS_ON()
107 join_for_testing_returned_.Set(); 109 join_for_testing_returned_.Set();
108 #endif 110 #endif
109 } 111 }
110 112
(...skipping 30 matching lines...) Expand all
141 static_cast<MessageLoopForIO*>(service_thread_.message_loop())); 143 static_cast<MessageLoopForIO*>(service_thread_.message_loop()));
142 #else 144 #else
143 base::MakeUnique<TaskTracker>(); 145 base::MakeUnique<TaskTracker>();
144 #endif 146 #endif
145 147
146 // Instantiate DelayedTaskManager. Needs to happen after starting the service 148 // Instantiate DelayedTaskManager. Needs to happen after starting the service
147 // thread to get its task_runner(). 149 // thread to get its task_runner().
148 delayed_task_manager_ = 150 delayed_task_manager_ =
149 base::MakeUnique<DelayedTaskManager>(service_thread_.task_runner()); 151 base::MakeUnique<DelayedTaskManager>(service_thread_.task_runner());
150 152
153 single_thread_task_runner_manager_ =
154 MakeUnique<SchedulerSingleThreadTaskRunnerManager>(
155 worker_pool_params_vector, worker_pool_index_for_traits_callback_,
156 task_tracker_.get(), delayed_task_manager_.get());
157
151 // Callback invoked by workers to re-enqueue a sequence in the appropriate 158 // Callback invoked by workers to re-enqueue a sequence in the appropriate
152 // PriorityQueue. 159 // PriorityQueue.
153 const SchedulerWorkerPoolImpl::ReEnqueueSequenceCallback 160 const SchedulerWorkerPoolImpl::ReEnqueueSequenceCallback
154 re_enqueue_sequence_callback = 161 re_enqueue_sequence_callback =
155 Bind(&TaskSchedulerImpl::ReEnqueueSequenceCallback, Unretained(this)); 162 Bind(&TaskSchedulerImpl::ReEnqueueSequenceCallback, Unretained(this));
156 163
157 // Start worker pools. 164 // Start worker pools.
158 for (const auto& worker_pool_params : worker_pool_params_vector) { 165 for (const auto& worker_pool_params : worker_pool_params_vector) {
159 // Passing pointers to objects owned by |this| to 166 // Passing pointers to objects owned by |this| to
160 // SchedulerWorkerPoolImpl::Create() is safe because a TaskSchedulerImpl 167 // SchedulerWorkerPoolImpl::Create() is safe because a TaskSchedulerImpl
(...skipping 23 matching lines...) Expand all
184 // in |sequence|. 191 // in |sequence|.
185 const TaskTraits traits = 192 const TaskTraits traits =
186 sequence->PeekTaskTraits().WithPriority(sort_key.priority()); 193 sequence->PeekTaskTraits().WithPriority(sort_key.priority());
187 194
188 GetWorkerPoolForTraits(traits)->ReEnqueueSequence(std::move(sequence), 195 GetWorkerPoolForTraits(traits)->ReEnqueueSequence(std::move(sequence),
189 sort_key); 196 sort_key);
190 } 197 }
191 198
192 } // namespace internal 199 } // namespace internal
193 } // namespace base 200 } // namespace base
OLDNEW
« no previous file with comments | « base/task_scheduler/task_scheduler_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698