|
|
Created:
3 years, 10 months ago by charliea (OOO until 10-5) Modified:
3 years, 10 months ago Reviewers:
eakuefner CC:
catapult-reviews_chromium.org, tracing-review_chromium.org Target Ref:
refs/heads/master Project:
catapult Visibility:
Public. |
DescriptionMake some small style cleanups in tracing_metric.html
This is a modified reland of https://codereview.chromium.org/2654433016,
which hard to be reverted because it used Object.values() even though
our Windows version of d8 doesn't yet support that function.
Review-Url: https://codereview.chromium.org/2700163002
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/0bd2f03bedefec8ca50c162a346d56c2b0b89e3e
Patch Set 1 #Patch Set 2 : Synced to head #Patch Set 3 : Replaced dictionaryValues with Object.values #Patch Set 4 : Synced to head #Patch Set 5 : Object.Values => Object.values #Patch Set 6 : #Messages
Total messages: 38 (22 generated)
charliea@chromium.org changed reviewers: + eakuefner@chromium.org
The CQ bit was checked by charliea@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Catapult Windows Tryserver on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Wi...)
Looks like we're getting Object.entries failures on Windows, sigh.
The CQ bit was checked by charliea@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-catapult-committers". Note that this has nothing to do with OWNERS files.
PTAL
lgtm
lgtm
The CQ bit was checked by charliea@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by charliea@chromium.org
The CQ bit was checked by charliea@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from eakuefner@chromium.org Link to the patchset: https://codereview.chromium.org/2700163002/#ps40001 (title: "Replaced dictionaryValues with Object.values")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Catapult Windows Tryserver on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Wi...)
The CQ bit was checked by charliea@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from eakuefner@chromium.org Link to the patchset: https://codereview.chromium.org/2700163002/#ps60001 (title: "Synced to head")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Catapult Windows Tryserver on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Wi...)
The CQ bit was checked by charliea@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from eakuefner@chromium.org Link to the patchset: https://codereview.chromium.org/2700163002/#ps80001 (title: "Object.Values => Object.values")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Catapult Linux Tryserver on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Li...) Catapult Presubmit on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Pr...)
The CQ bit was checked by charliea@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from eakuefner@chromium.org Link to the patchset: https://codereview.chromium.org/2700163002/#ps100001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 100001, "attempt_start_ts": 1487880080651620, "parent_rev": "c7131a7075d25cc165d824903ff99ccae424f4b4", "commit_rev": "0bd2f03bedefec8ca50c162a346d56c2b0b89e3e"}
Message was sent while issue was closed.
Description was changed from ========== Make some small style cleanups in tracing_metric.html This is a modified reland of https://codereview.chromium.org/2654433016, which hard to be reverted because it used Object.values() even though our Windows version of d8 doesn't yet support that function. ========== to ========== Make some small style cleanups in tracing_metric.html This is a modified reland of https://codereview.chromium.org/2654433016, which hard to be reverted because it used Object.values() even though our Windows version of d8 doesn't yet support that function. Review-Url: https://codereview.chromium.org/2700163002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapu... ==========
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as https://chromium.googlesource.com/external/github.com/catapult-project/catapu... |