Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issue 2700123002: Revert of service_manager: More consistent Service lifecycle API (Closed)

Created:
3 years, 10 months ago by cfroussios
Modified:
3 years, 10 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of service_manager: More consistent Service lifecycle API (patchset #3 id:40001 of https://codereview.chromium.org/2700693004/ ) Reason for revert: CL is the suspected culprit of breaking ContentBrowserTest.BrowserCrashCallStack Original issue's description: > service_manager: More consistent Service lifecycle API > > This introduces OnStartFailed() to be invoked in lieu of OnStart() > if the Service pipe breaks before OnStart() can be invoked. > > This disambiguates the meaning of OnStop(), ensuring that it will > now only be called in the event that OnStart() happened first. > > BUG=672614 > R=sky@chromium.org > > Review-Url: https://codereview.chromium.org/2700693004 > Cr-Commit-Position: refs/heads/master@{#451252} > Committed: https://chromium.googlesource.com/chromium/src/+/6cadd4324682783aa817250cdf229c022086666a TBR=sky@chromium.org,rockot@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=672614 Review-Url: https://codereview.chromium.org/2700123002 Cr-Commit-Position: refs/heads/master@{#451274} Committed: https://chromium.googlesource.com/chromium/src/+/da1a75010d17285002bab1fda9ca510119c69814

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -55 lines) Patch
M services/service_manager/public/cpp/lib/service.cc View 2 chunks +0 lines, -17 lines 0 comments Download
M services/service_manager/public/cpp/lib/service_context.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M services/service_manager/public/cpp/service.h View 3 chunks +15 lines, -29 lines 0 comments Download
M services/service_manager/public/cpp/service_context.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
cfroussios
Created Revert of service_manager: More consistent Service lifecycle API
3 years, 10 months ago (2017-02-17 10:05:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2700123002/1
3 years, 10 months ago (2017-02-17 10:06:23 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/da1a75010d17285002bab1fda9ca510119c69814
3 years, 10 months ago (2017-02-17 10:07:40 UTC) #6
Ken Rockot(use gerrit already)
3 years, 10 months ago (2017-02-17 16:33:38 UTC) #7
Message was sent while issue was closed.
On 2017/02/17 at 10:07:40, commit-bot wrote:
> Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/da1a75010d17285002bab1fda9ca...

Please try to include links to example failures when reverting a CL, as
otherwise the author has to spend considerably more time trying to find out
exactly what failed (platform, build config, etc).

Powered by Google App Engine
This is Rietveld 408576698