Chromium Code Reviews
DescriptionRevert of service_manager: More consistent Service lifecycle API (patchset #3 id:40001 of https://codereview.chromium.org/2700693004/ )
Reason for revert:
CL is the suspected culprit of breaking ContentBrowserTest.BrowserCrashCallStack
Original issue's description:
> service_manager: More consistent Service lifecycle API
>
> This introduces OnStartFailed() to be invoked in lieu of OnStart()
> if the Service pipe breaks before OnStart() can be invoked.
>
> This disambiguates the meaning of OnStop(), ensuring that it will
> now only be called in the event that OnStart() happened first.
>
> BUG=672614
> R=sky@chromium.org
>
> Review-Url: https://codereview.chromium.org/2700693004
> Cr-Commit-Position: refs/heads/master@{#451252}
> Committed: https://chromium.googlesource.com/chromium/src/+/6cadd4324682783aa817250cdf229c022086666a
TBR=sky@chromium.org,rockot@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=672614
Review-Url: https://codereview.chromium.org/2700123002
Cr-Commit-Position: refs/heads/master@{#451274}
Committed: https://chromium.googlesource.com/chromium/src/+/da1a75010d17285002bab1fda9ca510119c69814
Patch Set 1 #
Messages
Total messages: 7 (3 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||