service_manager: More consistent Service lifecycle API

service_manager: More consistent Service lifecycle API

This introduces OnStartFailed() to be invoked in lieu of OnStart()
if the Service pipe breaks before OnStart() can be invoked.

This disambiguates the meaning of OnStop(), ensuring that it will
now only be called in the event that OnStart() happened first.

BUG=672614
R=sky@chromium.org

Review-Url: https://codereview.chromium.org/2700693004
Cr-Commit-Position: refs/heads/master@{#451252}
Committed: https://chromium.googlesource.com/chromium/src/+/6cadd4324682783aa817250cdf229c022086666a

[Ken Rockot(use gerrit already), 2017-02-16 21:51:00]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[Ken Rockot(use gerrit already), 2017-02-16 21:52:24]

As discussed earlier this week. Note that this shouldn't affect existing code
behavior in any meaningful way; it's just a semantic API improvement.

[commit-bot: I haz the power, 2017-02-16 21:53:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2017-02-16 23:37:27]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-16 23:38:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2017-02-16 23:38:32]

OK - the ServiceContext now always calls QuitNow() after invoking
OnStartFailed(). If we happen to want to make this behavior optional like it is
for OnStop() I think we can add that later.

[sky, 2017-02-16 23:59:37]

https://codereview.chromium.org/2700693004/diff/20001/services/service_manage...
File services/service_manager/public/cpp/service.h (right):

https://codereview.chromium.org/2700693004/diff/20001/services/service_manage...
services/service_manager/public/cpp/service.h:38: virtual void OnStartFailed();
Please document that right this is called QuitNow is called.

[sky, 2017-02-16 23:59:58]

LGTM

[Ken Rockot(use gerrit already), 2017-02-17 00:08:06]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[Ken Rockot(use gerrit already), 2017-02-17 00:09:07]

https://codereview.chromium.org/2700693004/diff/20001/services/service_manage...
File services/service_manager/public/cpp/service.h (right):

https://codereview.chromium.org/2700693004/diff/20001/services/service_manage...
services/service_manager/public/cpp/service.h:38: virtual void OnStartFailed();
On 2017/02/16 at 23:59:36, sky wrote:
> Please document that right this is called QuitNow is called.

Done (documented that the default impl calls it now)

[Ken Rockot(use gerrit already), 2017-02-17 00:09:11]

The CQ bit was unchecked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2017-02-17 00:09:12]

The CQ bit was checked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2017-02-17 00:09:12]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2700693004/#ps40001
(title: ".")

[commit-bot: I haz the power, 2017-02-17 00:10:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 04:43:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 04:43:35]

Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ken Rockot(use gerrit already), 2017-02-17 06:02:02]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2017-02-17 06:02:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 06:47:34]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487311322829740,
"parent_rev": "1767e59153ee506fe6394efe4018b4cd3f2a2671", "commit_rev":
"6cadd4324682783aa817250cdf229c022086666a"}

[commit-bot: I haz the power, 2017-02-17 06:48:11]

Description was changed from

==========
service_manager: More consistent Service lifecycle API

This introduces OnStartFailed() to be invoked in lieu of OnStart()
if the Service pipe breaks before OnStart() can be invoked.

This disambiguates the meaning of OnStop(), ensuring that it will
now only be called in the event that OnStart() happened first.

BUG=672614
R=sky@chromium.org
==========

to

==========
service_manager: More consistent Service lifecycle API

This introduces OnStartFailed() to be invoked in lieu of OnStart()
if the Service pipe breaks before OnStart() can be invoked.

This disambiguates the meaning of OnStop(), ensuring that it will
now only be called in the event that OnStart() happened first.

BUG=672614
R=sky@chromium.org

Review-Url: https://codereview.chromium.org/2700693004
Cr-Commit-Position: refs/heads/master@{#451252}
Committed:
https://chromium.googlesource.com/chromium/src/+/6cadd4324682783aa817250cdf22...
==========

[commit-bot: I haz the power, 2017-02-17 06:48:12]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/6cadd4324682783aa817250cdf22...

[cfroussios, 2017-02-17 10:05:57]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2700123002/ by cfroussios@chromium.org.

The reason for reverting is: CL is the suspected culprit of breaking
ContentBrowserTest.BrowserCrashCallStack.