Don't use magic strings/properties to communicate between compiler and runtime.

Don't use magic strings/properties to communicate between compiler and runtime.

R=sra@google.com

Committed: https://github.com/dart-lang/sdk/commit/5de7bb57823e3c65c3950085e63c44b553c09682

[floitsch, 2017-02-17 17:00:23]

floitsch@google.com changed reviewers:
+ sra@google.com

[sra1, 2017-02-22 04:23:52]

https://codereview.chromium.org/2700053003/diff/1/pkg/compiler/lib/src/js_emi...
File pkg/compiler/lib/src/js_emitter/class_stub_generator.dart (right):

https://codereview.chromium.org/2700053003/diff/1/pkg/compiler/lib/src/js_emi...
pkg/compiler/lib/src/js_emitter/class_stub_generator.dart:45: typeInits =
js('this.# = #', [namer.rtiFieldJsName, parameterName]);
This is the place I was telling you about.
See https://github.com/dart-lang/sdk/issues/28727
This code diff is from before the bug fix.

https://codereview.chromium.org/2700053003/diff/1/sdk/lib/_internal/js_runtim...
File sdk/lib/_internal/js_runtime/lib/shared/embedded_names.dart (right):

https://codereview.chromium.org/2700053003/diff/1/sdk/lib/_internal/js_runtim...
sdk/lib/_internal/js_runtime/lib/shared/embedded_names.dart:320: /// Name used
to store runtime-type information.
Name of JavaScript property used to store runtime-type information on instances
of parameterized classes.

[floitsch, 2017-02-22 12:58:06]

PTAL.

https://codereview.chromium.org/2700053003/diff/1/pkg/compiler/lib/src/js_emi...
File pkg/compiler/lib/src/js_emitter/class_stub_generator.dart (right):

https://codereview.chromium.org/2700053003/diff/1/pkg/compiler/lib/src/js_emi...
pkg/compiler/lib/src/js_emitter/class_stub_generator.dart:45: typeInits =
js('this.# = #', [namer.rtiFieldJsName, parameterName]);
On 2017/02/22 04:23:52, sra1 wrote:
> This is the place I was telling you about.
> See https://github.com/dart-lang/sdk/issues/28727
> This code diff is from before the bug fix.

Done.

https://codereview.chromium.org/2700053003/diff/1/sdk/lib/_internal/js_runtim...
File sdk/lib/_internal/js_runtime/lib/shared/embedded_names.dart (right):

https://codereview.chromium.org/2700053003/diff/1/sdk/lib/_internal/js_runtim...
sdk/lib/_internal/js_runtime/lib/shared/embedded_names.dart:320: /// Name used
to store runtime-type information.
On 2017/02/22 04:23:52, sra1 wrote:
> Name of JavaScript property used to store runtime-type information on
instances
> of parameterized classes.

Thanks!
done.

[sra1, 2017-02-22 17:20:44]

lgtm

[floitsch, 2017-02-22 17:32:29]

Description was changed from

==========
Don't use magic strings/properties to communicate between compiler and runtime.
==========

to

==========
Don't use magic strings/properties to communicate between compiler and runtime.

R=sra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/5de7bb57823e3c65c3950085e63c44b553c09682
==========

[floitsch, 2017-02-22 17:32:31]

Committed patchset #2 (id:20001) manually as
5de7bb57823e3c65c3950085e63c44b553c09682 (presubmit successful).