Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: pkg/compiler/lib/src/ssa/codegen.dart

Issue 2700053003: Don't use magic strings/properties to communicate between compiler and runtime. (Closed)
Patch Set: Small cleanup. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/ssa/codegen.dart
diff --git a/pkg/compiler/lib/src/ssa/codegen.dart b/pkg/compiler/lib/src/ssa/codegen.dart
index af474568e26708b69253a5502671b1a52729c3e7..5cd48daf59a16f2166c19f568c28ee24c6327130 100644
--- a/pkg/compiler/lib/src/ssa/codegen.dart
+++ b/pkg/compiler/lib/src/ssa/codegen.dart
@@ -2969,7 +2969,7 @@ class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
void visitTypeInfoReadRaw(HTypeInfoReadRaw node) {
use(node.inputs[0]);
js.Expression receiver = pop();
- push(js.js(r'#.#', [receiver, backend.namer.rtiFieldName]));
+ push(js.js(r'#.#', [receiver, backend.namer.rtiFieldJsName]));
}
void visitTypeInfoReadVariable(HTypeInfoReadVariable node) {
@@ -3061,7 +3061,7 @@ class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
js.Expression receiver = pop();
js.Expression helper =
backend.emitter.staticFunctionAccess(helperElement);
- js.Expression rtiFieldName = backend.namer.rtiFieldName;
+ js.Expression rtiFieldName = backend.namer.rtiFieldJsName;
push(js.js(r'#(#.# && #.#[#])', [
helper,
receiver,
« no previous file with comments | « pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart ('k') | sdk/lib/_internal/js_runtime/lib/js_rti.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698