pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart - Issue 2700053003: Don't use magic strings/properties to communicate between compiler and runtime.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart

Issue 2700053003: Don't use magic strings/properties to communicate between compiler and runtime. (Closed)

Patch Set: Small cleanup. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart

diff --git a/pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart b/pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart

index 613336b8bf846e64aad47c8482c83877ea97b315..3335c4a67ec6545d7461e42c4020053388379c2f 100644

--- a/pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart

+++ b/pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart

@@ -655,7 +655,7 @@ class FragmentEmitter {

List<js.Name> fieldNames =

cls.fields.map((Field field) => field.name).toList();

if (cls.hasRtiField) {

- fieldNames.add(namer.rtiFieldName);

+ fieldNames.add(namer.rtiFieldJsName);

}

Iterable<js.Name> assignments = fieldNames.map((js.Name field) {

« no previous file with comments | « pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart ('k') | pkg/compiler/lib/src/ssa/codegen.dart » ('j') | no next file with comments »