LogDog: Implement StreamName.Split.

LogDog: Implement StreamName.Split.

Implement StreamName.Split, which splits a StreamName into its last
(right-most) element and its base element.

BUG=chromium:692245
TEST=unit

Review-Url: https://codereview.chromium.org/2699943004
Committed: https://github.com/luci/luci-go/commit/842542a505b380cc816b217cdb642ecdfac922d2

[dnj, 2017-02-18 01:26:35]

dnj@chromium.org changed reviewers:
+ hinoka@chromium.org, nodir@chromium.org

[dnj, 2017-02-18 01:26:36]

PTAL

[nodir, 2017-02-18 05:01:51]

lgtm

https://codereview.chromium.org/2699943004/diff/1/logdog/common/types/streamn...
File logdog/common/types/streamname.go (right):

https://codereview.chromium.org/2699943004/diff/1/logdog/common/types/streamn...
logdog/common/types/streamname.go:236: // Split splits a StreamName on its last
path element, into a base (everything
"base" is somewhat confusing here. Term base is usually used for the last
element, e.g. https://godoc.org/path#Base

https://codereview.chromium.org/2699943004/diff/1/logdog/common/types/streamn...
logdog/common/types/streamname.go:248: func (s StreamName) Split() (base
StreamName, last StreamName) {
(base, last StreamName)

[dnj, 2017-02-18 06:09:31]

https://codereview.chromium.org/2699943004/diff/1/logdog/common/types/streamn...
File logdog/common/types/streamname.go (right):

https://codereview.chromium.org/2699943004/diff/1/logdog/common/types/streamn...
logdog/common/types/streamname.go:236: // Split splits a StreamName on its last
path element, into a base (everything
On 2017/02/18 05:01:51, nodir wrote:
> "base" is somewhat confusing here. Term base is usually used for the last
> element, e.g. https://godoc.org/path#Base

Change to "prefix".

https://codereview.chromium.org/2699943004/diff/1/logdog/common/types/streamn...
logdog/common/types/streamname.go:248: func (s StreamName) Split() (base
StreamName, last StreamName) {
On 2017/02/18 05:01:51, nodir wrote:
> (base, last StreamName)

Done.

[dnj, 2017-02-18 19:40:49]

The CQ bit was checked by dnj@chromium.org

[dnj, 2017-02-18 19:40:50]

The patchset sent to the CQ was uploaded after l-g-t-m from nodir@chromium.org
Link to the patchset: https://codereview.chromium.org/2699943004/#ps20001
(title: "comments")

[commit-bot: I haz the power, 2017-02-18 19:41:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-18 19:50:33]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487446849989400,
"parent_rev": "83c79129a89e615130fb4d067aef5034f52f8fde", "commit_rev":
"842542a505b380cc816b217cdb642ecdfac922d2"}

[commit-bot: I haz the power, 2017-02-18 19:50:36]

Description was changed from

==========
LogDog: Implement StreamName.Split.

Implement StreamName.Split, which splits a StreamName into its last
(right-most) element and its base element.

BUG=chromium:692245
TEST=unit
==========

to

==========
LogDog: Implement StreamName.Split.

Implement StreamName.Split, which splits a StreamName into its last
(right-most) element and its base element.

BUG=chromium:692245
TEST=unit

Review-Url: https://codereview.chromium.org/2699943004
Committed:
https://github.com/luci/luci-go/commit/842542a505b380cc816b217cdb642ecdfac922d2
==========

[commit-bot: I haz the power, 2017-02-18 19:50:37]

Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/842542a505b380cc816b217cdb642ecdfac922d2