Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2698413005: Annotee: Allow annotation subpath to be specified. (Closed)

Created:
3 years, 10 months ago by dnj
Modified:
3 years, 10 months ago
Reviewers:
nodir, hinoka
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Annotee: Allow annotation subpath to be specified. BUG=chromium:692245 TEST=unit Review-Url: https://codereview.chromium.org/2698413005 Committed: https://github.com/luci/luci-go/commit/83c79129a89e615130fb4d067aef5034f52f8fde

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -7 lines) Patch
M logdog/client/annotee/annotation/annotation.go View 1 chunk +0 lines, -6 lines 0 comments Download
M logdog/client/annotee/processor.go View 3 chunks +16 lines, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 8 (4 generated)
dnj
PTAL
3 years, 10 months ago (2017-02-18 01:26:29 UTC) #2
nodir
lgtm
3 years, 10 months ago (2017-02-18 04:58:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2698413005/1
3 years, 10 months ago (2017-02-18 19:31:53 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-18 19:39:31 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/83c79129a89e615130fb4d067aef5034f52f8fde

Powered by Google App Engine
This is Rietveld 408576698