Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Issue 2699933002: Re-ordering triggering priority of offline pages (Closed)

Created:
3 years, 10 months ago by RyanSturm
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Re-ordering triggering priority of offline pages Force offline when connected should be higher priority than offline previews. When users force an offline page, it makes little sense to show the offline previews UI, as chrome did not intervene to show a preview. BUG=692690 Review-Url: https://codereview.chromium.org/2697113002 Cr-Commit-Position: refs/heads/master@{#450829} (cherry picked from commit dfe9f69720945551289fd7dba30f1b825e72c830) Review-Url: https://codereview.chromium.org/2699933002 . Cr-Commit-Position: refs/branch-heads/2987@{#549} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/1589975e43f4456175169c1d379fe5382244096f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M chrome/browser/android/offline_pages/offline_page_request_job.cc View 2 chunks +10 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
RyanSturm
3 years, 10 months ago (2017-02-16 17:37:24 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1589975e43f4456175169c1d379fe5382244096f.

Powered by Google App Engine
This is Rietveld 408576698