Re-ordering triggering priority of offline pages

Re-ordering triggering priority of offline pages

Force offline when connected should be higher priority than offline
previews. When users force an offline page, it makes little sense to
show the offline previews UI, as chrome did not intervene to show a
preview.

BUG=692690
Review-Url: https://codereview.chromium.org/2697113002
Cr-Commit-Position: refs/heads/master@{#450829}
Committed: https://chromium.googlesource.com/chromium/src/+/dfe9f69720945551289fd7dba30f1b825e72c830

[RyanSturm, 2017-02-15 19:57:55]

The CQ bit was checked by ryansturm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-15 19:58:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[RyanSturm, 2017-02-15 20:32:03]

ryansturm@chromium.org changed reviewers:
+ jianli@chromium.org

[RyanSturm, 2017-02-15 20:32:04]

jianli: PTAL, thanks.

[commit-bot: I haz the power, 2017-02-15 21:19:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-15 21:19:29]

Dry run: This issue passed the CQ dry run.

[jianli, 2017-02-15 21:20:50]

lgtm

https://codereview.chromium.org/2697113002/diff/1/chrome/browser/android/offl...
File chrome/browser/android/offline_pages/offline_page_request_job.cc (right):

https://codereview.chromium.org/2697113002/diff/1/chrome/browser/android/offl...
chrome/browser/android/offline_pages/offline_page_request_job.cc:141:
offline_header.reason != OfflinePageHeader::Reason::RELOAD) {
Ideally, we probably need to add a new network state,
FORCE_OFFLINE_ON_PROHIBITIVELY_SLOW_NETWORK in order for better UMA report. But
I am fine with not doing this if we don't have the need to analyze this case.

[RyanSturm, 2017-02-15 21:22:39]

On 2017/02/15 21:20:50, jianli wrote:
> lgtm
> 
>
https://codereview.chromium.org/2697113002/diff/1/chrome/browser/android/offl...
> File chrome/browser/android/offline_pages/offline_page_request_job.cc (right):
> 
>
https://codereview.chromium.org/2697113002/diff/1/chrome/browser/android/offl...
> chrome/browser/android/offline_pages/offline_page_request_job.cc:141:
> offline_header.reason != OfflinePageHeader::Reason::RELOAD) {
> Ideally, we probably need to add a new network state,
> FORCE_OFFLINE_ON_PROHIBITIVELY_SLOW_NETWORK in order for better UMA report.
But
> I am fine with not doing this if we don't have the need to analyze this case.

That seems unnecessary because previews should be the last resort case.

[RyanSturm, 2017-02-15 21:22:44]

The CQ bit was checked by ryansturm@chromium.org

[commit-bot: I haz the power, 2017-02-15 21:23:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 23:01:23]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487193764527990, "parent_rev":
"02aad1bec1531836b02ec1666d75f592cad6fc1d", "commit_rev":
"dfe9f69720945551289fd7dba30f1b825e72c830"}

[commit-bot: I haz the power, 2017-02-15 23:02:07]

Description was changed from

==========
Re-ordering triggering priority of offline pages

Force offline when connected should be higher priority than offline
previews. When users force an offline page, it makes little sense to
show the offline previews UI, as chrome did not intervene to show a
preview.

BUG=692690
==========

to

==========
Re-ordering triggering priority of offline pages

Force offline when connected should be higher priority than offline
previews. When users force an offline page, it makes little sense to
show the offline previews UI, as chrome did not intervene to show a
preview.

BUG=692690

Review-Url: https://codereview.chromium.org/2697113002
Cr-Commit-Position: refs/heads/master@{#450829}
Committed:
https://chromium.googlesource.com/chromium/src/+/dfe9f69720945551289fd7dba30f...
==========

[commit-bot: I haz the power, 2017-02-15 23:02:09]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/dfe9f69720945551289fd7dba30f...