Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 2699633004: Revert of cros: ensure update check to complete at OOBE before allowing login (Closed)

Created:
3 years, 10 months ago by achuithb
Modified:
3 years, 10 months ago
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of cros: ensure update check to complete at OOBE before allowing login (patchset #3 id:80001 of https://codereview.chromium.org/2676383002/ ) Reason for revert: Believe this is causing a regression in linux builds Original issue's description: > cros: ensure update check to complete at OOBE before allowing login > > This CL updates the CrOS login flow to ensure the update check is > complete at OOBE before allowing the first user to log in. Without a > successful check for update, we can't be sure if there is a critical > update. To play safe and avoid missing any critical update during OOBE, > we modify the UI simply goes back to the network selection screen > instead of proceeding to the login screen. For the non-OOBE flow, we > don't want to block the users while failing to check for update, and > thus preseve the existing UI behavior to proceed to the login screen. > > BUG=chromium:683424 > TEST=Tested the following: > 1. Under the OOBE scenario, interrupt the network connectivity when > the UI is checking for update. Verify that the UI goes back to the > network selection screen. > 2. Repeat (1) under the non-OOBE scenario. Verify that the UI proceeds > to the login screen. > > Review-Url: https://codereview.chromium.org/2676383002 > Cr-Commit-Position: refs/heads/master@{#450428} > Committed: https://chromium.googlesource.com/chromium/src/+/ec6cb24b6ad420b32f0836b8e3d4767378b90b93 TBR=benchan@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:683424 Review-Url: https://codereview.chromium.org/2699633004 Cr-Commit-Position: refs/heads/master@{#450963} Committed: https://chromium.googlesource.com/chromium/src/+/f8969afdf8bb49522af51123fda1d2e4c5050444

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -52 lines) Patch
M chrome/browser/chromeos/login/wizard_controller.cc View 1 chunk +6 lines, -15 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller_browsertest.cc View 3 chunks +4 lines, -37 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
achuithb
Created Revert of cros: ensure update check to complete at OOBE before allowing login
3 years, 10 months ago (2017-02-16 14:15:40 UTC) #1
achuithb
3 years, 10 months ago (2017-02-16 14:20:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2699633004/1
3 years, 10 months ago (2017-02-16 14:21:09 UTC) #5
Roman Sorokin (ftl)
lgtm
3 years, 10 months ago (2017-02-16 14:22:00 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-16 14:57:48 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f8969afdf8bb49522af51123fda1...

Powered by Google App Engine
This is Rietveld 408576698