Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Unified Diff: chrome/browser/chromeos/login/wizard_controller_browsertest.cc

Issue 2699633004: Revert of cros: ensure update check to complete at OOBE before allowing login (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/login/wizard_controller.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/login/wizard_controller_browsertest.cc
diff --git a/chrome/browser/chromeos/login/wizard_controller_browsertest.cc b/chrome/browser/chromeos/login/wizard_controller_browsertest.cc
index 1cc76e305800bf0ec2bec239e273ba6cba18dffe..47988a3bed0a6da5984f5fd4e2b914c3e46d57e5 100644
--- a/chrome/browser/chromeos/login/wizard_controller_browsertest.cc
+++ b/chrome/browser/chromeos/login/wizard_controller_browsertest.cc
@@ -592,38 +592,6 @@
->GetCurrentTimezoneID()));
}
-// This test verifies that if WizardController fails to check for update before
-// the OOBE is marked complete, it goes back the network selection screen and
-// thus prevents the user from proceeding to log in.
-IN_PROC_BROWSER_TEST_F(WizardControllerFlowTest,
- ControlFlowErrorCheckingForUpdate) {
- CheckCurrentScreen(OobeScreen::SCREEN_OOBE_NETWORK);
- EXPECT_CALL(*mock_update_screen_, StartNetworkCheck()).Times(0);
- EXPECT_CALL(*mock_eula_screen_, Show()).Times(1);
- EXPECT_CALL(*mock_update_screen_, Show()).Times(0);
- EXPECT_CALL(*mock_network_screen_, Hide()).Times(1);
- OnExit(*mock_network_screen_, BaseScreenDelegate::NETWORK_CONNECTED);
-
- CheckCurrentScreen(OobeScreen::SCREEN_OOBE_EULA);
- EXPECT_CALL(*mock_eula_screen_, Hide()).Times(1);
- EXPECT_CALL(*mock_update_screen_, StartNetworkCheck()).Times(1);
- EXPECT_CALL(*mock_update_screen_, Show()).Times(1);
- OnExit(*mock_eula_screen_, BaseScreenDelegate::EULA_ACCEPTED);
-
- // Let update screen smooth time process (time = 0ms).
- content::RunAllPendingInMessageLoop();
-
- CheckCurrentScreen(OobeScreen::SCREEN_OOBE_UPDATE);
- EXPECT_CALL(*mock_update_screen_, Hide()).Times(1);
- EXPECT_CALL(*mock_eula_screen_, Show()).Times(0);
- EXPECT_CALL(*mock_auto_enrollment_check_screen_, Show()).Times(0);
- EXPECT_CALL(*mock_network_screen_, Show()).Times(1);
- EXPECT_CALL(*mock_network_screen_, Hide()).Times(0); // last transition
- OnExit(*mock_update_screen_,
- BaseScreenDelegate::UPDATE_ERROR_CHECKING_FOR_UPDATE);
- CheckCurrentScreen(OobeScreen::SCREEN_OOBE_NETWORK);
-}
-
// This test verifies that if WizardController fails to apply a non-critical
// update before the OOBE is marked complete, it allows the user to proceed to
// log in.
@@ -799,9 +767,9 @@
DISALLOW_COPY_AND_ASSIGN(WizardControllerErrorUpdateAfterCompletedOobeTest);
};
-// This test verifies that if WizardController fails to check for update or
-// apply an update (either critical or non-critical) after the OOBE is marked
-// complete, it allows the user to proceed to log in.
+// This test verifies that if WizardController fails to apply an update, either
+// critical or non-critical, after the OOBE is marked complete, it allows the
+// user to proceed to log in.
IN_PROC_BROWSER_TEST_P(WizardControllerErrorUpdateAfterCompletedOobeTest,
ControlFlowErrorUpdate) {
const BaseScreenDelegate::ExitCodes update_screen_exit_code = GetParam();
@@ -838,8 +806,7 @@
INSTANTIATE_TEST_CASE_P(
WizardControllerErrorUpdateAfterCompletedOobe,
WizardControllerErrorUpdateAfterCompletedOobeTest,
- testing::Values(BaseScreenDelegate::UPDATE_ERROR_CHECKING_FOR_UPDATE,
- BaseScreenDelegate::UPDATE_ERROR_UPDATING,
+ testing::Values(BaseScreenDelegate::UPDATE_ERROR_UPDATING,
BaseScreenDelegate::UPDATE_ERROR_UPDATING_CRITICAL_UPDATE));
class WizardControllerDeviceStateTest : public WizardControllerFlowTest {
« no previous file with comments | « chrome/browser/chromeos/login/wizard_controller.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698