Refactor to remove need for infiniteIntRect when computing rects in pre-paint

Refactor to remove need for infiniteIntRect when computing rects in pre-paint

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2699593006
Cr-Commit-Position: refs/heads/master@{#451250}
Committed: https://chromium.googlesource.com/chromium/src/+/a16900cd0e022d0ef255e55f121bfb8639194477

[chrishtr, 2017-02-16 19:09:12]

Description was changed from

==========
none


none

BUG=
==========

to

==========
none


none

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2017-02-16 19:10:11]

Description was changed from

==========
none


none

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Refactor to remove need for infiniteIntRect when computing rects in pre-paint

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2017-02-16 19:10:38]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-16 19:11:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 20:50:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 20:50:03]

Dry run: This issue passed the CQ dry run.

[chrishtr, 2017-02-16 20:51:30]

chrishtr@chromium.org changed reviewers:
+ wkorman@chromium.org

[chrishtr, 2017-02-16 21:16:47]

chrishtr@chromium.org changed reviewers:
+ pdr@chromium.org

[wkorman, 2017-02-16 21:45:32]

lgtm

https://codereview.chromium.org/2699593006/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp (right):

https://codereview.chromium.org/2699593006/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp:117: if
(isAncestorOfOrEqualTo(context.clip, ancestorState.clip()))
Do we have existing tests that cover this logic? PrePaintTreeWalkTest looks like
it mainly has clip caching and subsequence related tests.

https://codereview.chromium.org/2699593006/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/graphics/paint/FloatClipRect.h (right):

https://codereview.chromium.org/2699593006/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/paint/FloatClipRect.h:48: void
moveBy(const FloatPoint& offset) {
Maybe worth starting a FloatClipRectTest. Would obviously be pretty simple, but,
eh.

[chrishtr, 2017-02-16 23:48:28]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2017-02-16 23:48:28]

The patchset sent to the CQ was uploaded after l-g-t-m from wkorman@chromium.org
Link to the patchset: https://codereview.chromium.org/2699593006/#ps20001
(title: "none")

[chrishtr, 2017-02-16 23:48:32]

https://codereview.chromium.org/2699593006/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp (right):

https://codereview.chromium.org/2699593006/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp:117: if
(isAncestorOfOrEqualTo(context.clip, ancestorState.clip()))
On 2017/02/16 at 21:45:32, wkorman wrote:
> Do we have existing tests that cover this logic? PrePaintTreeWalkTest looks
like it mainly has clip caching and subsequence related tests.

Yes, but they are layout tests. The situation happens when a composited
element has an out of flow descendant that is not clipped.
sourceToDestinationClipRect actually does "handle" this situation now
(falling back to an infinite rect),
but in my original patch I added it to produce results that are the same
as before. Perhaps I should try to remove this.

https://codereview.chromium.org/2699593006/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/graphics/paint/FloatClipRect.h (right):

https://codereview.chromium.org/2699593006/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/paint/FloatClipRect.h:48: void
moveBy(const FloatPoint& offset) {
On 2017/02/16 at 21:45:32, wkorman wrote:
> Maybe worth starting a FloatClipRectTest. Would obviously be pretty simple,
but, eh.

Done.

[commit-bot: I haz the power, 2017-02-16 23:50:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 23:58:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 23:58:19]

Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[chrishtr, 2017-02-17 00:02:53]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2017-02-17 00:02:53]

The patchset sent to the CQ was uploaded after l-g-t-m from wkorman@chromium.org
Link to the patchset: https://codereview.chromium.org/2699593006/#ps40001
(title: "none")

[chrishtr, 2017-02-17 00:04:37]

The CQ bit was unchecked by chrishtr@chromium.org

[chrishtr, 2017-02-17 00:04:44]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2017-02-17 00:04:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 02:08:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 02:08:36]

Try jobs failed on following builders:
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[chrishtr, 2017-02-17 02:09:17]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2017-02-17 02:11:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 04:14:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 04:14:22]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)

[chrishtr, 2017-02-17 05:46:52]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2017-02-17 05:47:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 06:37:32]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487310412501240,
"parent_rev": "c1dd762facbeb164cedf88e07ba7f46458d49659", "commit_rev":
"a16900cd0e022d0ef255e55f121bfb8639194477"}

[commit-bot: I haz the power, 2017-02-17 06:38:08]

Description was changed from

==========
Refactor to remove need for infiniteIntRect when computing rects in pre-paint

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Refactor to remove need for infiniteIntRect when computing rects in pre-paint

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2699593006
Cr-Commit-Position: refs/heads/master@{#451250}
Committed:
https://chromium.googlesource.com/chromium/src/+/a16900cd0e022d0ef255e55f121b...
==========

[commit-bot: I haz the power, 2017-02-17 06:38:09]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/a16900cd0e022d0ef255e55f121b...