Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Issue 2699573002: Revert of Consolidate c/b/chromeos/printing target with its own BUILD file. (Closed)

Created:
3 years, 10 months ago by dominickn
Modified:
3 years, 10 months ago
Reviewers:
stevenjb, Carlson, skau
CC:
chromium-reviews, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Consolidate c/b/chromeos/printing target with its own BUILD file. (patchset #2 id:20001 of https://codereview.chromium.org/2695133002/ ) Reason for revert: Broke the ChromeOS build. https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20ChromeOS/builds/29370 Original issue's description: > Consolidate c/b/chromeos/printing target with its own BUILD file. > > Since the migration to GN, we want more granular build files. Do this > for chromeos/printing. > > BUG= > > Review-Url: https://codereview.chromium.org/2695133002 > Cr-Commit-Position: refs/heads/master@{#450540} > Committed: https://chromium.googlesource.com/chromium/src/+/5c6e9df99e78b8666e7016aae94ac2503c9adce9 TBR=justincarlson@chromium.org,stevenjb@chromium.org,skau@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2699573002 Cr-Commit-Position: refs/heads/master@{#450552} Committed: https://chromium.googlesource.com/chromium/src/+/2fa29b4e1d070a0b3a64a172c29f71282d86d7d7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -73 lines) Patch
M chrome/browser/chromeos/BUILD.gn View 5 chunks +38 lines, -2 lines 0 comments Download
D chrome/browser/chromeos/printing/BUILD.gn View 1 chunk +0 lines, -70 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
dominickn
Created Revert of Consolidate c/b/chromeos/printing target with its own BUILD file.
3 years, 10 months ago (2017-02-15 03:51:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2699573002/1
3 years, 10 months ago (2017-02-15 03:52:34 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-15 03:54:02 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2fa29b4e1d070a0b3a64a172c29f...

Powered by Google App Engine
This is Rietveld 408576698