Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2695133002: Consolidate c/b/chromeos/printing target with its own BUILD file. (Closed)

Created:
3 years, 10 months ago by skau
Modified:
3 years, 10 months ago
Reviewers:
stevenjb, Carlson
CC:
chromium-reviews, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Consolidate c/b/chromeos/printing target with its own BUILD file. Since the migration to GN, we want more granular build files. Do this for chromeos/printing. BUG= Review-Url: https://codereview.chromium.org/2695133002 Cr-Commit-Position: refs/heads/master@{#450540} Committed: https://chromium.googlesource.com/chromium/src/+/5c6e9df99e78b8666e7016aae94ac2503c9adce9

Patch Set 1 #

Patch Set 2 : declare dependency on printing from ui #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -38 lines) Patch
M chrome/browser/chromeos/BUILD.gn View 5 chunks +2 lines, -38 lines 0 comments Download
A chrome/browser/chromeos/printing/BUILD.gn View 1 chunk +70 lines, -0 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 22 (13 generated)
skau
3 years, 10 months ago (2017-02-14 21:04:52 UTC) #3
Carlson
lgtm Wooo A+++ change would review again.
3 years, 10 months ago (2017-02-14 21:43:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2695133002/20001
3 years, 10 months ago (2017-02-14 21:46:05 UTC) #11
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 10 months ago (2017-02-14 21:46:07 UTC) #13
skau
stevenjb@: Can you take a look? This looks like the first package in c/b/chromeos that ...
3 years, 10 months ago (2017-02-14 22:02:12 UTC) #15
stevenjb
lgtm
3 years, 10 months ago (2017-02-14 22:24:05 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2695133002/20001
3 years, 10 months ago (2017-02-14 23:58:35 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/5c6e9df99e78b8666e7016aae94ac2503c9adce9
3 years, 10 months ago (2017-02-15 01:23:47 UTC) #21
dominickn
3 years, 10 months ago (2017-02-15 03:51:51 UTC) #22
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2699573002/ by dominickn@chromium.org.

The reason for reverting is: Broke the ChromeOS build.
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Chrom....

Powered by Google App Engine
This is Rietveld 408576698