|
|
DescriptionStop to trigger virtual keyboard on focus event.
After the update, virtual keyboard is shown only when an text input element is focused when mouse or pointer
left event is received by Chrome. For example if user clicks a button with the Enter key and then focus is
moved to a text input element programatically, virtual keyboard doesn't show up.
BUG=642513
TEST=manually using http://jsbin.com/gicawoxewe/edit?html,output .
- Clicking sync button triggers virtual keyboard because when mouse left event is fired, the focus is already moved to the text input element.
- Clicking async button doesn't trigger virtual keyboard because when when mouse left event is fired, the focus is not moved yet.
Review-Url: https://codereview.chromium.org/2699533009
Cr-Commit-Position: refs/heads/master@{#458326}
Committed: https://chromium.googlesource.com/chromium/src/+/a398f50b910cab76e2b923db3c5b4c690ff49160
Patch Set 1 #Patch Set 2 : . #Messages
Total messages: 22 (14 generated)
The CQ bit was checked by oka@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
.
The CQ bit was checked by oka@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by oka@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
Description was changed from ========== Stop to trigger virtual keyboard on focus event. BUG=642513 ========== to ========== Stop to trigger virtual keyboard on focus event. After the update, virtual keyboard is shown only when an text input element is focused when mouse or pointer left event is received by Chrome. For example if user clicks a button with the Enter key and then focus is moved to a text input element programatically, virtual keyboard doesn't show up. BUG=642513 TEST=manually using http://jsbin.com/gicawoxewe/edit?html,output . - Clicking sync button triggers virtual keyboard because when mouse left event is fired, the focus is already moved to the text input element. - Clicking async button doesn't trigger virtual keyboard because when when mouse left event is fired, the focus is not moved yet. ==========
oka@chromium.org changed reviewers: + yhanada@chromium.org
PTAL.
lgtm
oka@chromium.org changed reviewers: + kinuko@chromium.org
kinuko@ Could youreview changes in render_widget.cc? Thanks.
kinuko@ Could youreview changes in render_widget.cc? Thanks.
rs/lgtm
The CQ bit was checked by oka@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490074658020520, "parent_rev": "0b3748a3344c72d94fa98e7bbc7f57be70c65a02", "commit_rev": "a398f50b910cab76e2b923db3c5b4c690ff49160"}
Message was sent while issue was closed.
Description was changed from ========== Stop to trigger virtual keyboard on focus event. After the update, virtual keyboard is shown only when an text input element is focused when mouse or pointer left event is received by Chrome. For example if user clicks a button with the Enter key and then focus is moved to a text input element programatically, virtual keyboard doesn't show up. BUG=642513 TEST=manually using http://jsbin.com/gicawoxewe/edit?html,output . - Clicking sync button triggers virtual keyboard because when mouse left event is fired, the focus is already moved to the text input element. - Clicking async button doesn't trigger virtual keyboard because when when mouse left event is fired, the focus is not moved yet. ========== to ========== Stop to trigger virtual keyboard on focus event. After the update, virtual keyboard is shown only when an text input element is focused when mouse or pointer left event is received by Chrome. For example if user clicks a button with the Enter key and then focus is moved to a text input element programatically, virtual keyboard doesn't show up. BUG=642513 TEST=manually using http://jsbin.com/gicawoxewe/edit?html,output . - Clicking sync button triggers virtual keyboard because when mouse left event is fired, the focus is already moved to the text input element. - Clicking async button doesn't trigger virtual keyboard because when when mouse left event is fired, the focus is not moved yet. Review-Url: https://codereview.chromium.org/2699533009 Cr-Commit-Position: refs/heads/master@{#458326} Committed: https://chromium.googlesource.com/chromium/src/+/a398f50b910cab76e2b923db3c5b... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/a398f50b910cab76e2b923db3c5b... |