Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 2699533009: Stop to trigger virtual keyboard on focus event. (Closed)

Created:
3 years, 10 months ago by oka
Modified:
3 years, 9 months ago
Reviewers:
kinuko, yhanada
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Stop to trigger virtual keyboard on focus event. After the update, virtual keyboard is shown only when an text input element is focused when mouse or pointer left event is received by Chrome. For example if user clicks a button with the Enter key and then focus is moved to a text input element programatically, virtual keyboard doesn't show up. BUG=642513 TEST=manually using http://jsbin.com/gicawoxewe/edit?html,output . - Clicking sync button triggers virtual keyboard because when mouse left event is fired, the focus is already moved to the text input element. - Clicking async button doesn't trigger virtual keyboard because when when mouse left event is fired, the focus is not moved yet. Review-Url: https://codereview.chromium.org/2699533009 Cr-Commit-Position: refs/heads/master@{#458326} Committed: https://chromium.googlesource.com/chromium/src/+/a398f50b910cab76e2b923db3c5b4c690ff49160

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M content/renderer/render_widget.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (14 generated)
oka
.
3 years, 10 months ago (2017-02-16 21:57:52 UTC) #3
oka
PTAL.
3 years, 9 months ago (2017-03-16 09:18:56 UTC) #12
yhanada
lgtm
3 years, 9 months ago (2017-03-17 03:37:04 UTC) #13
oka
kinuko@ Could youreview changes in render_widget.cc? Thanks.
3 years, 9 months ago (2017-03-20 22:52:26 UTC) #15
oka
kinuko@ Could youreview changes in render_widget.cc? Thanks.
3 years, 9 months ago (2017-03-20 22:52:28 UTC) #16
kinuko
rs/lgtm
3 years, 9 months ago (2017-03-21 05:03:51 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2699533009/20001
3 years, 9 months ago (2017-03-21 05:37:56 UTC) #19
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 06:31:29 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a398f50b910cab76e2b923db3c5b...

Powered by Google App Engine
This is Rietveld 408576698