Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(913)

Unified Diff: content/renderer/render_widget.cc

Issue 2699533009: Stop to trigger virtual keyboard on focus event. (Closed)
Patch Set: . Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_widget.cc
diff --git a/content/renderer/render_widget.cc b/content/renderer/render_widget.cc
index 36baa7d16f680e4c03d1381814a7452e3295e3ae..2940307d30515c505e22df9c0532be89cda77a66 100644
--- a/content/renderer/render_widget.cc
+++ b/content/renderer/render_widget.cc
@@ -1790,7 +1790,14 @@ void RenderWidget::OnDragSourceSystemDragEnded() {
}
void RenderWidget::showVirtualKeyboardOnElementFocus() {
+#if defined(OS_CHROMEOS)
+ // On ChromeOS, virtual keyboard is triggered only when users leave the
+ // mouse button or the finger and a text input element is focused at that
+ // time. Focus event itself shouldn't trigger virtual keyboard.
+ UpdateTextInputState();
+#else
ShowVirtualKeyboard();
+#endif
// TODO(rouslan): Fix ChromeOS and Windows 8 behavior of autofill popup with
// virtual keyboard.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698